Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for bearer-token protected batch job result URLs #382

Open
soxofaan opened this issue Apr 15, 2021 · 0 comments
Open

Option for bearer-token protected batch job result URLs #382

soxofaan opened this issue Apr 15, 2021 · 0 comments
Labels
breaking Breaking changes, requires a major-version (2.0.0 for example)
Milestone

Comments

@soxofaan
Copy link
Member

(This is spin-off of the discussion at #380)

Batch job results currently have to be published as signed URLs that do not require bearer auth or other headers, to make it possible to download the results in applications where it is hard to set the necessary headers.

Signed URLs however come with some security disadvantages: they are simple URLs that give direct access to resources that we normally protected with real authentication in other parts of the API. Expiry times should mitigate the security risk and there is currently a proposal to also allow invalidating of signed URLs (see #341/#381). However, a back-end is currently not required to support any of these solutions.

An alternative to signed URLs for batch job result downloads is using the standard bearer auth headers we use elsewhere. This is probably trivial if the back-end stores the result files itself, but even if the results are on third party storage it should be possible to proxy these results through backend URLs.

possible solutions:

  • add a request parameter to /jobs/{job_id}/results to toggle between signed URLs and http header based download URLs
  • change the single href field under the assets items in the response to a list of multiple URLs: e.g. in pseudo code [{"type": "signed", "href": "https//s3.com/...."}, {"type": "auth", "href": "https://backend/...."}]
@m-mohr m-mohr modified the milestones: 2.0.0, future Apr 15, 2021
@m-mohr m-mohr added the breaking Breaking changes, requires a major-version (2.0.0 for example) label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes, requires a major-version (2.0.0 for example)
Projects
None yet
Development

No branches or pull requests

2 participants