Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers to list implementations+specs #92

Open
LukeWeidenwalker opened this issue Apr 17, 2023 · 1 comment
Open

Add helpers to list implementations+specs #92

LukeWeidenwalker opened this issue Apr 17, 2023 · 1 comment

Comments

@LukeWeidenwalker
Copy link
Contributor

Address issue raised in Open-EO/openeo-python-client#411 (comment).

Unless I'm missing something, I think this can be done more compactly with:

> for name, func in inspect.getmembers(
>     openeo_processes_dask.process_implementations,
>     inspect.isfunction,
> ):
>     process_registry[name] = Process(
>         spec=getattr(openeo_processes.specs, name),
>         implementation=func
>     )
> Also, wouldn't it be better that openeo_processes_dask provide helpers to list implementations/spec, instead of having to use ugly inspect.getmembers and getattr constructs?
@LukeWeidenwalker
Copy link
Contributor Author

Another comment here is that currently the submodule specs includes specs that aren't actually implemented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant