Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predict_curve: labels should not be optional #453

Open
LukeWeidenwalker opened this issue Aug 22, 2023 · 1 comment
Open

predict_curve: labels should not be optional #453

LukeWeidenwalker opened this issue Aug 22, 2023 · 1 comment
Milestone

Comments

@LukeWeidenwalker
Copy link
Contributor

Process ID: predict_curve

Describe the issue:
The docs for the labels parameter of predict_curve say this:

"The labels to predict values for. If no labels are given, predicts values only for no-data (null) values in the data cube."

However, in the 2.0.0 version of predict_curve, there's no longer the option to pass in a datacube, so labels shouldn't be allowed to be null.

Proposed solution:
Make labels a required parameter for this process and remove the section about filling in nodata-values from the documentation.

@m-mohr
Copy link
Member

m-mohr commented Aug 22, 2023

Happy to review a PR.

@m-mohr m-mohr added this to the 2.0.0 milestone Sep 30, 2023
@m-mohr m-mohr modified the milestones: 2.0.0, 2.1.0 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants