Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip workflows if executed processes are not in the list of processes / process levels #10

Closed
m-mohr opened this issue Dec 19, 2023 · 6 comments · Fixed by #37
Closed

Comments

@m-mohr
Copy link
Member

m-mohr commented Dec 19, 2023

Workflow tests should only run if executed processes are in the list of processes / process levels, otherwise they should be skipped.

See fixtures processes and process_levels.

@clausmichele
Copy link
Member

How do we do with load_stac? If not present I should try to use an openEO collection with which name?

@m-mohr
Copy link
Member Author

m-mohr commented Dec 19, 2023

In other tests I simply skipped tests that can't be fulfilled by the backend due to missing processes, unless a given processing level requires the process (then it should be reported as error).

@clausmichele
Copy link
Member

But then it would be impossible to test the SentinelHub back-end or any other back-end not yet supporting load_stac, but able to index the sample collection, despite load_stac not being a process of the L1.

@clausmichele
Copy link
Member

clausmichele commented Dec 20, 2023

@m-mohr a couple of things:

  1. Are the conformance level public already? I know they are here, but it's a private repo: https://github.com/openEOPlatform/architecture-docs/blob/master/interface/processes/results/profiles.md. Edit: nevermind, I found them, you mention the page in your processes README. https://openeo.org/documentation/1.0/developers/profiles/processes.html
  2. Should we also document the tests that are skipped due to a missing process? Skipping them directly would not be so informative imho.

@m-mohr
Copy link
Member Author

m-mohr commented Dec 20, 2023

You can of course also make it configurable to provide a collection ID, but if neither a collection ID nor load_stac is abailable, skip it with a notice. I also do it that way in my tests, feel free to check it for examples.

  1. Yes, published on https://openeo.org/documentation/1.0/developers/profiles/api.html and https://openeo.org/documentation/1.0/developers/profiles/processes.html
  2. I skip them with a message, see my examples. Show them with the -rs flag in the CLI.

@clausmichele
Copy link
Member

Implemented in the last commit: 39c9ec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants