Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wetterdienst to the "Data Mining" section #14

Open
amotl opened this issue Nov 30, 2020 · 3 comments
Open

Add Wetterdienst to the "Data Mining" section #14

amotl opened this issue Nov 30, 2020 · 3 comments

Comments

@amotl
Copy link

amotl commented Nov 30, 2020

Hi there,

first things first: Thank you for conceiving and maintaining this excellent repository.

Thanks @mmaelicke for adding dwdweather2 through #9 and also thanks to @schymans and @rcnijzink for adding comments on that the other day.

I just wanted to give you a quick heads-up that we moved on and are developing Wetterdienst these days. We also just recognized that @raoulcollenteur already included it at [1].

So, I wanted to humbly ask about early feedback in this regard. Shall we just submit a pull request which adds Wetterdienst to the Data Mining section [2] or are there also other things to take care about?

With kind regards,
Andreas.

[1] https://github.com/raoulcollenteur/Python-Hydrology-Tools#data-collection
[2] https://github.com/Open-Environmental-Science/awesome-open-hydrology#data-mining

cc @gutzbenj

@amotl amotl changed the title Add Wetterdienst to the Data Mining section Add Wetterdienst to the "Data Mining" section Nov 30, 2020
@mmaelicke
Copy link
Member

Hey @amotl ,
Just had a look at Wetterdienst and that one looks great and, indeed, awesome!

I think submitting a pull request is the way to go. There is the awesome manifesto to spot the important stuff that has to be in the linked repository. I think Wetterdinst is really, really well maintained and developed, so that will be fine.
Contributing guidelines are also available, but I think you are well familiar with the process @amotl

@amotl
Copy link
Author

amotl commented Dec 1, 2020

Hi again,

thank you already for the kind words, @mmaelicke. We are currently busy but look forward to come back here and submit a pull request for adding Wetterdienst.

Keep up the spirit and with kind regards,
Andreas.

@schymans
Copy link
Member

schymans commented Dec 2, 2020

This is really cool, thanks! If you are too busy, one of us could also create such a PR, but it would be much better if you as a developer could do it for more direct and faster communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants