Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer router.replace() instead of .push() for 404 redirects #13

Open
fredlawl opened this issue Apr 27, 2021 · 0 comments
Open

Prefer router.replace() instead of .push() for 404 redirects #13

fredlawl opened this issue Apr 27, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fredlawl
Copy link

In a case of a redirect to a 404, a user can't go back to the previous page before the 404 because the .push() will put in a redirect loop that we want to avoid.
@fredlawl fredlawl changed the title Prefer router.replace() instead of .push() for 404 pages Prefer router.replace() instead of .push() for 404 redirects Apr 27, 2021
@fredlawl fredlawl added enhancement New feature or request good first issue Good for newcomers labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fredlawl