Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot does not handle holidays or missing events #14

Open
fredlawl opened this issue Sep 14, 2022 · 0 comments
Open

Bot does not handle holidays or missing events #14

fredlawl opened this issue Sep 14, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fredlawl
Copy link
Contributor

fredlawl commented Sep 14, 2022

The bot should have a (internal/external/cache?) list of known U.S. holidays, and if an event is going to happen the day of the holiday, don't post a message for that week.

Same for missing events, if we know there's no upcoming event for the week, don't announce. In cases we don't know if there's an event or not, such as meetup isn't hooked up/enabled, assume there is an event--but respect the holiday rule.

TODO: https://github.com/Open-SGF/discord-bot/blob/main/bot/bot.go#L109

Aside: This is an interesting one because maybe we pull a list from an outside source on bot startup, and cache that to a file we can read from weekly.

EDIT: Added detail for missing meetup events

@fredlawl fredlawl added enhancement New feature or request good first issue Good for newcomers labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant