feat: create geocoding function #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitchedmob
requested changes
Jan 17, 2022
src/utils.ts
Outdated
| @@ -7,3 +10,22 @@ export function parseNumber(str?: string): number | undefined { | |||
| export function _throw(msg: string): never { | |||
| throw msg; | |||
| } | |||
|
|
|||
| export async function getCoordsFromAddress(address: string): Promise<any> { | |||
There was a problem hiding this comment.
We need to write a return type for this function. using any is a bad idea. For now you could probably just add an interface ICoords that lives next to this function.
ethanzitting
force-pushed
the
feat/address-to-coords
branch
from
ba50ee8
to
d08951a
Compare
ethanzitting
changed the title
ethanzitting
force-pushed
the
feat/address-to-coords
branch
from
cf54af8
to
31a6f4c
Compare
ethanzitting
force-pushed
the
feat/address-to-coords
branch
from
d1057fd
to
e7f97d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7