Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more math functions #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

js6450
Copy link

@js6450 js6450 commented Oct 1, 2018

added =randInt, arrayLen, factorize and 3D distance calc functions and its tests

@shiffman
Copy link
Member

shiffman commented Oct 1, 2018

Hopefully I resolved the merge conflicts correctly! @NHibiki @js6450 feel free to check my work! If the tests pass, I'll merge 😄

@shiffman
Copy link
Member

shiffman commented Oct 1, 2018

Ooops.

@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these files that are added to .idea directory?

package.json Outdated
"repository": {
"type": "git",
"url": "git+https://github.com/js6450/UnitTestingCI.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these URLs should point to Open-Source-Studio-at-ITP rather than js6450?

Change from js6450 -> Open-Source-Studio-at-ITP/UnitTestingCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants