Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full JSON data of country calling codes #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Full JSON data of country calling codes #3

wants to merge 2 commits into from

Conversation

D31F43
Copy link

@D31F43 D31F43 commented Sep 22, 2018

Full JSON data of country calling codes

shiffman
shiffman reviewed Sep 22, 2018
View reviewed changes
data/technology/list_of_country_calling_codes.json Outdated
{
"count": 280,
"updated": 2018,
"data": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense for this to be something more descriptive? "countries"?

data/technology/list_of_country_calling_codes.json Show resolved Hide resolved
@D31F43
Copy link
Author

D31F43 commented Sep 23, 2018

Thanks for noticing me. I reviewed most of corpora data and found most of them had source and description entry for user to know immediately what data they are using. So, I added these and pushed another commit.

shiffman
shiffman approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiffman shiffman shiffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D31F43 @shiffman