Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a list of Disney films #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mengzhenxiao
Copy link

No description provided.

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just the one comment.

@hugovk
Copy link

hugovk commented Sep 25, 2018

@shiffman What's the one comment? :)

@shiffman
Copy link
Member

@hugovk oh, how odd somehow I missed submitting it with the review? Will re-add!

@@ -0,0 +1,1618 @@
[
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the standard format for corpora is to start with an object and then include the list as a named array. It's also good practice to include "description" and "source" properties for more info about the data and where it was compiled from!

{
  "description": "____________",
  "source": "____________",
  "films": [ ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants