Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function request - list where a given parameter is used #1490

Open
PavelBal opened this issue Oct 11, 2024 · 5 comments
Open

Function request - list where a given parameter is used #1490

PavelBal opened this issue Oct 11, 2024 · 5 comments

Comments

@PavelBal
Copy link
Member

A function that takes a parameter/parameter path and lists all formulas resp. parameters/reactions etc. where this parameter is used in a simulation.

@Yuri05 @msevestre Do you think it can/should be done in .NET, or try to implement this directly in R using the "Export" of a simulation?

@rwmcintosh @rengelke @Felixmil

@rwmcintosh
Copy link
Member

If we plan to give a view to users in the suite then we should only create the list in c# and make the method available to R. No sense implementing that twice.

Maybe you were not thinking about a view for suite but if it will be useful we should add it.

@PavelBal
Copy link
Member Author

@Yuri05
Copy link
Member

Yuri05 commented Oct 16, 2024

Btw we have a lot of parameters in simulations, which are effectively not used (e.g. protein-model specific parameters in a small molecules model etc.).
Currently, those parameters are identified only in SimModel. This information was propagated to the Matlab-Toolbox (Open-Systems-Pharmacology/OSPSuite.SimModel#59), but I don't remember if it was propagated to R (probably not).
The general idea was to propagate this to the simulation in PK-Sim, MoBi and R to
a) clearly mark those parameters as unused for the user
b) avoid using them e.g. in sensitivity calculation, PIs etc. (which would be just waste of computational time).
There is an open discussion on this topic: Open-Systems-Pharmacology/PK-Sim#1050

EDIT:

but I don't remember if it was propagated to R (probably not)

For sure, it wasn't. Matlab-Toolbox worked via SimModel with sxmls, so the info was available. But not now for R via pkmls.

@msevestre
Copy link
Member

We are using this in R I believe to filter out parameters for the SA.

@Yuri05
Copy link
Member

Yuri05 commented Oct 17, 2024

We are using this in R I believe to filter out parameters for the SA.

really? interesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants