Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary upload job is uploading all artefacts regardless if that run created them. #215

Open
nabobalis opened this issue Jul 12, 2024 · 1 comment

Comments

@nabobalis
Copy link
Contributor

We have two action runs to compile wheels, one for a range of platforms and one for aarch64.

If you see https://github.com/sunpy/sunpy/actions/runs/9915099064 for an example.

The upload step for the non-aarch64 run also tries to upload the aarch64 wheel which feels like it shouldn't be doing?

Is this expected behaviour?

@ConorMacBride
Copy link
Member

Hi @nabobalis! The upload section for both publish jobs currently downloads all build artifacts for the ci.yml workflow run matching dist-*, which is why you are seeing the wrong wheels. So it looks like we need to update publish.yml to use more unique build artifact names; ones that include the job name used within the caller workflow e.g. publish_exotic. I'm not sure how we access that name within the reusable workflow but it should be somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants