Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

Allow multi-line strings (common in SET records). #70

Open
abargnesi opened this issue May 23, 2016 · 0 comments
Open

Allow multi-line strings (common in SET records). #70

abargnesi opened this issue May 23, 2016 · 0 comments
Assignees
@nbargnesi

Comments

@abargnesi
Copy link
Member

abargnesi commented May 23, 2016 •
edited

A multi-line SET record will result in an incorrect AST. The value() node is expected but an incomplete string() node is returned:

(set [[:@complete, nil]]
  (name []
    (identifier [[:@complete, true]] "Evidence"))
  (string [[:@complete, false]] "this is a multi\n"))

This issue causes OpenBEL/openbel-api#114.
abargnesi pushed a commit that referenced this issue May 23, 2016
added set's name() and value() children
8c1d2c1 
added NL as terminal in order to properly yield.

this has the side effect of reporting incomplete strings when the
closing double quote is on the next line.

opened issue #70 to track the multi-line string issue
abargnesi pushed a commit that referenced this issue Jun 9, 2016
Revert "fixes OpenBEL/openbel-api#114"
c7a0f2d 
This reverts commit 7c493a1.

The incorrect AST experienced here is due to #70 so we're reverting this
fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbargnesi nbargnesi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abargnesi @nbargnesi