Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

Infinite loop in complex components expansion #12

Open
ghost opened this issue Jan 14, 2016 · 5 comments
Open

Infinite loop in complex components expansion #12

ghost opened this issue Jan 14, 2016 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jan 14, 2016

While working on the large_corpus I found a strange situation and I was wondering if this corresponds to a correct encoding of a biological fact or if it is simply a typo.

In the large_corpus.bel file we have the following sentence:

p(HGNC:CD3D) hasComponent complex(SCOMP:"CD3 Complex”)

and in the named-complexes.bel file we have the sentence:

complex(SCOMP:"CD3 Complex") hasComponent p(HGNC:CD3D)

which produces an infinite loop when trying to recursively expand the components of any complex containing p(HGNC:CD3D) or complex(SCOMP:"CD3 Complex”).

Is it possible that the sentence in large_corpus.bel has the subject and object inverted?

@wshayes
Copy link
Member

wshayes commented Jan 14, 2016

That is definitely a bug. complex(SCOMP:"CD3 Complex") hasComponent p(HGNC:CD3D) is correct. Feel free to correct it or I can do it later today.

Thanks!

On Jan 14, 2016, at 8:47 AM, Roberto Mosca [email protected] wrote:

While working on the large_corpus I found a strange situation and I was wondering if this corresponds to a correct encoding of a biological fact or if it is simply a typo

In the large_corpusbel file we have the following sentence:

p(HGNC:CD3D) hasComponent complex(SCOMP:"CD3 Complex”)

and in the named-complexesbel file we have the sentence:

complex(SCOMP:"CD3 Complex") hasComponent p(HGNC:CD3D)

Which produces an infinite loop when trying to recursively expand the components of any complex containing p(HGNC:CD3D) or complex(SCOMP:"CD3 Complex”)

Is it possible that the sentence in large_corpusbel is reversed?


Reply to this email directly or view it on GitHub #12.

@wshayes
Copy link
Member

wshayes commented Jan 14, 2016

Need to update large_corpus.xbel as well. Tony - can you convert large_corpus.bel to *.xbel?

@wshayes
Copy link
Member

wshayes commented Jan 14, 2016

Thanks Robert for the pull request to fix this and the other statements you found.

On Jan 14, 2016, at 8:47 AM, Roberto Mosca [email protected] wrote:

While working on the large_corpus I found a strange situation and I was wondering if this corresponds to a correct encoding of a biological fact or if it is simply a typo

In the large_corpusbel file we have the following sentence:

p(HGNC:CD3D) hasComponent complex(SCOMP:"CD3 Complex”)

and in the named-complexesbel file we have the sentence:

complex(SCOMP:"CD3 Complex") hasComponent p(HGNC:CD3D)

Which produces an infinite loop when trying to recursively expand the components of any complex containing p(HGNC:CD3D) or complex(SCOMP:"CD3 Complex”)

Is it possible that the sentence in large_corpusbel is reversed?


Reply to this email directly or view it on GitHub #12.

@ghost
Copy link
Author

ghost commented Jan 14, 2016

You're welcome! :)

@ghost
Copy link
Author

ghost commented Jan 14, 2016

I found another such situation...

abargnesi pushed a commit that referenced this issue Jan 14, 2016
Thanks to @robmosca for improvements to the corpora.

refs #12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants