Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map doesn't reflect the latest coordinates of an area #1095

Closed
heliodor opened this issue Feb 13, 2024 · 5 comments
Closed

Map doesn't reflect the latest coordinates of an area #1095

heliodor opened this issue Feb 13, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@heliodor
Copy link

I updated the coordinates for an area and the map hasn't been updated (even minutes later).

Tried it for two more sub-areas and the same problem.

Or maybe it's a shortcoming of the current design but from the user's point of view, it's a bug.

@heliodor
Copy link
Author

Example: click the link with the coordinates and compare to the map at the bottom of the page:
https://openbeta.io/area/cb5ef655-d4ad-576a-9acc-7ba2a83fefb3/la-escalera

@vnugent vnugent added the bug Something isn't working label Feb 16, 2024
@vnugent
Copy link
Contributor

vnugent commented Feb 16, 2024

Pending backend PR 391 will update the maptiles as frequently as possible.

FYI in recent backend changes only coordinates of leaf (aka "crag") areas are used to calculate their parent's bounding boxes and the polygon since it doesn't make sense for a large area to have a single point.

The area edit page needs to disable/enable coordinates edit based on the isLeaf attribute.

@vnugent vnugent added the help wanted Extra attention is needed label Feb 16, 2024
@heliodor
Copy link
Author

heliodor commented Feb 20, 2024

To add some nuance to the coordinates of an area:

It makes sense to put the coordinates of a crag on the parking lot, not the actual rock. It fits my mental model: If I'm at home and I think of heading to ABC crag, I'm thinking of the parking lot, not a particular rock. When I think of going to a sector, I'm thinking of the actual rock.

But really, this is making up for the lack of certain details for the area. Maybe areas should have one or more "arrival points" with coordinates. Or even more detailed fields. Consider incorporating all approach trails into the bounding box for the area.

@vnugent
Copy link
Contributor

vnugent commented Feb 21, 2024

The maptiles exporter job now runs every 2 hrs (can be adjusted as needed). I'll submit a new PR for enabling/disabling area coordinates input when it makes sense.

Please continue the finer-grained area metadata discussion here: #1101

@vnugent
Copy link
Contributor

vnugent commented Feb 23, 2024

Fixed in OpenBeta/openbeta-graphql#391 and #1102

@vnugent vnugent closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants