From dbc5659cb24e5d0438a480cce93bd1296fc94f1f Mon Sep 17 00:00:00 2001 From: Viet Nguyen <3805254+vnugent@users.noreply.github.com> Date: Sat, 9 Dec 2023 20:43:53 -0700 Subject: [PATCH] fix: build break (#366) * fix: build break * don't push docker img on pr --- .github/workflows/nodejs.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 9d4c773a..95989644 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -13,15 +13,15 @@ on: jobs: # deploy to staging by commiting to api-server-deployment repo deploy-staging: - runs-on: ubuntu-latest - if: github.ref_name == 'develop' + runs-on: ubuntu-22.04 + # if: github.ref_name == 'develop' needs: docker steps: - name: 'Checkout Project' uses: 'actions/checkout@v4' with: fetch-depth: 1 - repository: 'api-server-deployment' + repository: 'openbeta/api-server-deployment' token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }} - uses: imranismail/setup-kustomize@v2 - run: | @@ -40,7 +40,7 @@ jobs: # deploy to prod by commiting to api-server-deployment repo deploy-prod: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 if: startsWith(github.ref, 'refs/tags/v') needs: docker steps: @@ -48,7 +48,7 @@ jobs: uses: 'actions/checkout@v4' with: fetch-depth: 1 - repository: 'api-server-deployment' + repository: 'openbeta/api-server-deployment' token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }} - uses: imranismail/setup-kustomize@v2 - run: | @@ -66,7 +66,8 @@ jobs: # build docker image and push to registry docker: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 + if: github.event_name != 'pull_request' needs: test steps: - name: 'Checkout Project' @@ -106,7 +107,7 @@ jobs: # setup basic machine to run all kinds of tests: lint, unit, integration, types test: - runs-on: 'ubuntu-latest' + runs-on: 'ubuntu-22.04' steps: - name: 'Checkout Project' uses: 'actions/checkout@v3'