Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climb createdBy and createdAt not set #218

Closed
Tracked by #273
vnugent opened this issue Jan 28, 2023 · 5 comments
Closed
Tracked by #273

Climb createdBy and createdAt not set #218

vnugent opened this issue Jan 28, 2023 · 5 comments
Labels
bug Something isn't working complexity - Medium help wanted Extra attention is needed
Milestone

Comments

@vnugent
Copy link
Contributor

vnugent commented Jan 28, 2023

When I create new climbs on openbeta.io using the bulk editor, createdBy, createdAt, updatedBy are not set.

https://github.com/OpenBeta/openbeta-graphql/blob/develop/src/model/MutableClimbDataSource.ts#L140


Screen Shot 2023-01-28 at 8 44 10 AM

@vnugent vnugent added bug Something isn't working complexity - Medium help wanted Extra attention is needed labels Jan 28, 2023
@vnugent vnugent modified the milestones: v0.6, v0.7 Jan 28, 2023
@CocoisBuggy CocoisBuggy self-assigned this Feb 27, 2023
@CocoisBuggy
Copy link
Contributor

I'll look into this, it looks like the code in the linked file should be sorted a little bit anyhow

@vnugent
Copy link
Contributor Author

vnugent commented Feb 28, 2023

@CocoisBuggy
It would be great if you can help fix this one! While it's low impact it's highly visible as many users are now editing pages. Thank you.

@vnugent vnugent modified the milestones: v0.7, M9 Apr 27, 2023
@vnugent
Copy link
Contributor Author

vnugent commented May 3, 2023

I came across this issue while working on #273. It's actually a frontend bug - fixing it in OpenBeta/open-tacos#800

@CocoisBuggy
Copy link
Contributor

Excellent! I am a bit perplexed though. Shouldn't these fields should be inferred from auth context rather than simply being trusted as parameters given by the front end...?

@vnugent
Copy link
Contributor Author

vnugent commented May 3, 2023

When a user performs an edit, the backend validates the user uuid and roles in the JWT token and correctly records it in the database. This real cause behind this issue has to do with React code incorrectly displaying user uuid / username field.

@vnugent vnugent closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working complexity - Medium help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants