Skip to content

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Sep 25, 2025

Proposed changes

  • reintroduce performance improvement of elFindByIds by using filter query

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 25, 2025
@JeremyCloarec JeremyCloarec marked this pull request as ready for review September 26, 2025 07:28
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.96%. Comparing base (a9935e7) to head (5ebed72).
⚠️ Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
...ti-platform/opencti-graphql/src/database/engine.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12548      +/-   ##
==========================================
+ Coverage   65.72%   65.96%   +0.24%     
==========================================
  Files         745      745              
  Lines       75311    75589     +278     
  Branches     8521     8783     +262     
==========================================
+ Hits        49501    49866     +365     
+ Misses      25810    25723      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec JeremyCloarec merged commit 4e68067 into master Oct 8, 2025
11 checks passed
@JeremyCloarec JeremyCloarec deleted the oob/elFindByIdsPerf branch October 8, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants