BUG: Clubs should not be able to use more than their points allowed #2

dompatmore · 2020-07-03T11:13:57Z

When:

A secretary redeems more points than they have available, which would leave them in the negative

Then:

They receive a confirmation message

Expected:

They should not be able to redeem more points than available; this should be done within the UI. 
The redeemed points should be correctly deducted from the club's total.

The text was updated successfully, but these errors were encountered:

and OpenClassrooms-Student-Center#5 + refactoring

…le - fix and tests - fix: ui: booking.html: html input attribute min set to 1 and max set to club["points"] - fix: server.py: purchase_places(): conditional structure implemented, checks redeemed points amount against competition places available - tests: class TestPurchase created: method: test_should_not_use_more_points_than_have - tests: class TestPurchase: method: test_should_deduct_points_from_club

…le - Tests Improvement - tests: conftest.py: config fixture to avoid repetition in test_server.py - UI: welcome.html: added a span to localize more efficiently the 'club_points_left'

… info - fix: bug already fixed when fixing issue [OpenClassrooms-Student-Center#2] as it was specified: 'The redeemed points should be correctly deducted from the club's total.' -UI: welcome.html: implementation of a table to better show the points redemption and update after a booking

…Student-Center#4)

found another bug during testing : it was possible to buy more places than available, fixed too.

…unto a negative number

… spend more than they have

…ython_Testing

…penClassrooms-Student-Center#2

-BUG: Clubs should not be able to use more than their points allowed- fixed. Booking Form won't allow number greater than points available.

…se to book places equals the available points of the club

…ooms-Student-Center#2

…Center#6

A club can no longer spend more points than it has Issue OpenClassrooms-Student-Center#2

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README * refactor(app): flake8 html report 100% clean * refactor(app): remove unused fixtures * fix(welcome.hmtl): adde operator = to fix bug

* feat(board.html): add template for points display board * feat(server): add route for points display board * feat(board.html): complete template * test(test_points_board): start testing happy path * feat(board.html): add condition if no clubs in json * test(test_points_board): add sad path to test * test(units/): add test_unlimited_points.py * fix(server): add condition to limit purchase * fix(booking.html): add display of flash message * test(units/): test_unlimited_points.py passed * test(units/): change docstrings in test_unlimited_points.py * test(units/): done test_unlimited_points.py * fix(issue): [OpenClassrooms-Student-Center#2] * test(units/): add test_points_not_update.py with TDD approch added test and failed * fix(server): add substraction points after book places * test(units/): run test_points_not_update.py and passed * fix(issue): [OpenClassrooms-Student-Center#6] * test(units/): add test_book_under_12.py with TDD method: started with failed test * fix(server): add condition if book more 12 places * test(units/): complete test_book_under_12.py and run tests passed * fix(issue): [OpenClassrooms-Student-Center#4] * test(functional/): add & complete test_route.py * fix(404.html): add 404 handler and template * fix(500.html): add 500 handler and template * test(functional/): add & complete test_load_json.py * test(integration/): add & complete test of app * fix(server): issue book more than places available * test(integration/): cleanup test_app * test(coverage/): make changes to have 100% test coverage * test(requirements.txt): install Locust * test(performance/): configure locust * test(performance/): add README * refactor(app): flake8 html report 100% clean * refactor(app): remove unused fixtures * fix(welcome.hmtl): adde operator = to fix bug * style(app): add css

…lowed OpenClassrooms-Student-Center#2

Issue OpenClassrooms-Student-Center#2 fixed + tests created

…put places / purchasePlaces-add club substration points

to respect the app specifications and closes some issues Resolves OpenClassrooms-Student-Center#2, resolves OpenClassrooms-Student-Center#4, resolves OpenClassrooms-Student-Center#5, resolves OpenClassrooms-Student-Center#6,

…at most the number of points available

…ed the bug by introducing conditional checks and appropriate flash messages. Fixes OpenClassrooms-Student-Center#2.

…ore points than available

…penClassrooms-Student-Center#2

PabloLec added a commit to PabloLec/oc_gudlift that referenced this issue Jul 6, 2021

Fix #1, OpenClassrooms-Student-Center#2, OpenClassrooms-Student-Center#4

0d624ed

and OpenClassrooms-Student-Center#5 + refactoring

mjeammet referenced this issue in mjeammet/DAPY-P11_gudlft Dec 10, 2021

add ui form contraints + test issue #2

286e0d3

mjeammet referenced this issue in mjeammet/DAPY-P11_gudlft Dec 17, 2021

fixing issue #1 and #2

a5af2ce

mjeammet referenced this issue in mjeammet/DAPY-P11_gudlft Dec 28, 2021

clubs cannot book more than allowed/available (#2 and OpenClassrooms-…

c0caa41

…Student-Center#4)

MilhouseVP added a commit to MilhouseVP/Python_Testing that referenced this issue Jan 3, 2022

bug OpenClassrooms-Student-Center#2 fixed.

3ff9693

found another bug during testing : it was possible to buy more places than available, fixed too.

Madscientiste added a commit to Madscientiste/OpenClassrooms_P11 that referenced this issue Feb 17, 2022

fixed (OpenClassrooms-Student-Center#2), Can't make a competition go …

8b7666e

…unto a negative number

ribandgel pushed a commit to ribandgel/Python_Testing that referenced this issue Mar 17, 2022

Fixes OpenClassrooms-Student-Center#2

4d7f375

bdibon added a commit to bdibon/Python_Testing that referenced this issue Mar 21, 2022

Fix issue OpenClassrooms-Student-Center#2 clubs should not be able to…

f3dacd1

… spend more than they have

zionhigt referenced this issue in zionhigt/Python_Testing Mar 27, 2022

Test for issue #2

f11f073

zionhigt referenced this issue in zionhigt/Python_Testing Mar 27, 2022

Stronger test for issue #2

06847ed

This was referenced Mar 29, 2022

Purchase places/bug/fix #58

Closed

Purchase places/bug/fix #59

Closed

josayko added a commit to josayko-courses/p11_gudlft that referenced this issue Apr 19, 2022

Fixes OpenClassrooms-Student-Center#2 OpenClassrooms-Student-Center/P…

bce9c27

…ython_Testing

massouathyassine added a commit to massouathyassine/gudlftP11 that referenced this issue May 6, 2022

BUG: Clubs should not be able to use more than their points allowed O…

df9b8ce

…penClassrooms-Student-Center#2

Pascal273 added a commit to Pascal273/Python_Testing that referenced this issue May 8, 2022

Issue OpenClassrooms-Student-Center#2

328e68f

-BUG: Clubs should not be able to use more than their points allowed- fixed. Booking Form won't allow number greater than points available.

Pascal273 added a commit to Pascal273/Python_Testing that referenced this issue May 11, 2022

Bug OpenClassrooms-Student-Center#2 fixed - max number of points to u…

efd4204

…se to book places equals the available points of the club

Luc-Aka-Evy added a commit to Luc-Aka-Evy/Gudlift that referenced this issue May 19, 2022

fix issue OpenClassrooms-Student-Center/Python_Testing#2

695af22

Aponovi added a commit to Aponovi/Python_Testing that referenced this issue May 30, 2022

fix issue OpenClassrooms-Student-Center#2

ccd9761

Aponovi added a commit to Aponovi/Python_Testing that referenced this issue Jun 1, 2022

already fix issue OpenClassrooms-Student-Center#6 in issue OpenClassr…

e327905

…ooms-Student-Center#2

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 9, 2022

Fix Issue OpenClassrooms-Student-Center#2

9aae803

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 9, 2022

Update Tests Issue OpenClassrooms-Student-Center#2

f52f715

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 10, 2022

Update test issue OpenClassrooms-Student-Center#2

3bac974

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 10, 2022

Update test issue OpenClassrooms-Student-Center#2

00e97db

jogubo pushed a commit to jogubo/oc-python-testing that referenced this issue Jun 13, 2022

fix issue OpenClassrooms-Student-Center#2

f44eca1

SelHel added a commit to SelHel/Python_Testing that referenced this issue Jun 14, 2022

Merge branch of issue OpenClassrooms-Student-Center#2

09afd0a

jogubo pushed a commit to jogubo/oc-python-testing that referenced this issue Jun 14, 2022

fix issue OpenClassrooms-Student-Center#2 and OpenClassrooms-Student-…

51735aa

…Center#6

Deadjuju added a commit to Deadjuju/P11_OC_Python_Testing that referenced this issue Jul 11, 2022

fix(server): control the points of a club

55adf08

A club can no longer spend more points than it has Issue OpenClassrooms-Student-Center#2

Mattgris6 added a commit to Mattgris6/OC_DAPython_Projet11_Gudlft that referenced this issue Nov 16, 2022

Fix and test bug OpenClassrooms-Student-Center#2

cc5a695

Mattgris6 added a commit to Mattgris6/OC_DAPython_Projet11_Gudlft that referenced this issue Nov 17, 2022

Merge branch 'bug/OpenClassrooms-Student-Center#2'

39e2426

selaouni added a commit to selaouni/Projet11 that referenced this issue Dec 6, 2022

Bug fixing: Clubs should not be able to use more than their points al…

729c0a7

…lowed OpenClassrooms-Student-Center#2

selaouni added a commit to selaouni/Projet11 that referenced this issue Dec 8, 2022

bug nbr OpenClassrooms-Student-Center#2 fixing: update

24def75

Bimarsto added a commit to Bimarsto/Python_Testing that referenced this issue Jan 20, 2023

Issue2

68cbd66

Issue OpenClassrooms-Student-Center#2 fixed + tests created

VisualDev-FR added a commit to VisualDev-FR/openclassrooms-P11 that referenced this issue Mar 31, 2023

Fixes OpenClassrooms-Student-Center#2

571163a

VisualDev-FR added a commit to VisualDev-FR/openclassrooms-P11 that referenced this issue Apr 21, 2023

Fixes OpenClassrooms-Student-Center#2

c1d1b6b

Jighart mentioned this issue Apr 25, 2023

Bug/club should not use more than allowed points Jighart/P11-Gudlft#17

Merged

JLenseele added a commit to JLenseele/Project_11 that referenced this issue Apr 26, 2023

fix OpenClassrooms-Student-Center#2 issue -> booking-add max value in…

6075e95

…put places / purchasePlaces-add club substration points

kivtorsm added a commit to kivtorsm/OCP11 that referenced this issue Jun 21, 2023

issue OpenClassrooms-Student-Center#2 user number of places input is …

9b4da7d

…at most the number of points available

kivtorsm added a commit to kivtorsm/OCP11 that referenced this issue Jun 22, 2023

issue OpenClassrooms-Student-Center#2 user number of places input is …

6b676db

…at most the number of points available

Maiphuongthao mentioned this issue Jul 27, 2023

2 bug allowed points #148

Closed

CeeG33 referenced this issue in CeeG33/oc-cg-p11 Sep 11, 2023

Resolution of bug #2

cf3598d

CeeG33 referenced this issue in CeeG33/oc-cg-p11 Sep 11, 2023

Tests réussis pour le bug #2

0eed48d

DomninBenoit added a commit to DomninBenoit/gudlift that referenced this issue Dec 11, 2023

Correction pour l'issue OpenClassrooms-Student-Center#2

ddf0e9a

ErnestoAquino added a commit to ErnestoAquino/Python_Testing that referenced this issue Dec 29, 2023

Fix issue OpenClassrooms-Student-Center#2: Prevent clubs from using m…

7f30003

…ore points than available

This was referenced Jan 25, 2024

BUG: Clubs should not be able to use more than their points allowed Mimi1706/Python_Testing#2

Closed

BUG: Clubs should not be able to use more than their points allowed Mimi1706/Python_Testing#5

Merged

GrolschSec added a commit to GrolschSec/gudlft that referenced this issue Feb 12, 2024

Correcting bug where clubs can spend more points than they have, see O…

2bf2d3f

…penClassrooms-Student-Center#2

AlexBotswana added a commit to AlexBotswana/Python_Testing that referenced this issue Feb 20, 2024

Fix Bug No negative account OpenClassrooms-Student-Center#2

d085d32

AlexBotswana mentioned this issue Feb 20, 2024

Bug no negative account #215

Open

geo1310 added a commit to geo1310/Python_Testing that referenced this issue Apr 16, 2024

Resolve OpenClassrooms-Student-Center#2 : Club Points validation

9edf726

ClaireRuysschaert mentioned this issue Apr 19, 2024

Bug/Clubs should not be able to use more than their points allowed ClaireRuysschaert/P11_GUDLFT#2

Merged

kenza12 mentioned this issue Apr 21, 2024

Bugfix/issue 2 point limit kenza12/Python_Testing#1

Merged

br-imen linked a pull request May 30, 2024 that will close this issue

Bug/clubs should not be able to use more than their points allowed #226

Open

mumz0 mentioned this issue Aug 30, 2024

Bugfix/club booking mumz0/Python_Testing#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Clubs should not be able to use more than their points allowed #2

BUG: Clubs should not be able to use more than their points allowed #2

dompatmore commented Jul 3, 2020 •

edited by HayVThom

Loading

BUG: Clubs should not be able to use more than their points allowed #2

BUG: Clubs should not be able to use more than their points allowed #2

Comments

dompatmore commented Jul 3, 2020 • edited by HayVThom Loading

dompatmore commented Jul 3, 2020 •

edited by HayVThom

Loading