-
Notifications
You must be signed in to change notification settings - Fork 122
modified types???? #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
modified types???? #2319
Conversation
|
so true github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly not a fan of the JSON solution, and it makes some things like new /datum{foo = new} impossible, but this is a fine stepping stone.
|
oh yeh gotta fix that too |
…into modifedtypespossibly
…into modifedtypespossibly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is generally upsetting to take expressions and smuggle them into the runtime in json format. I realise this was always going to be kinda hacky, but ew.
The modified types tests also contain atoms now, which they shouldn't anymore. Please change them to datums instead of objects.
This is behaviour that works in BYOND but not here:
/obj
var/a = 5
/proc/RunTest()
var/obj/o = /obj{a=6}
ASSERT((new o).a == 6)
Seems to work good on paradise and goon though!
Fixes #473
Implements modified types by smuggling a json of the modified types all the way to createobject
please review my code thoroughly, i suck! there's probably a lot of things that can be improved!