Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit and lint #79

Open
jthorton opened this issue Dec 6, 2024 · 3 comments
Open

Add pre-commit and lint #79

jthorton opened this issue Dec 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jthorton
Copy link
Contributor

jthorton commented Dec 6, 2024

Now that we have pre-commit setup in gufe we should follow the example and happy it here!

@jthorton jthorton added the enhancement New feature or request label Dec 6, 2024
@jthorton jthorton self-assigned this Dec 6, 2024
@IAlibay
Copy link
Member

IAlibay commented Dec 6, 2024

It probably would be best to let @atravitz set the org standard for linting before we go ahead and do it for all the repos.

I guess that I'm saying here @jthorton is, if it's not blocking you, I'd wait a bit on this (unless @atravitz is happy to go ahead with the current status in gufe).

@atravitz
Copy link
Contributor

atravitz commented Dec 6, 2024

I'm in favor of this but want to make some decisions up front first! We went ahead with a "something is better than nothing" approach in gufe, but I want to audit it a bit before applying things project-wide.

@jthorton - please let me know if you have any strong preferences about what linting standards we use!

@jthorton
Copy link
Contributor Author

jthorton commented Dec 9, 2024

No problem, I am happy to wait, my only request is black!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants