We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several endpoints using SyncCursorPage have a implementation for before and after that don't make sense given the current id generation. Example:
SyncCursorPage
before
after
id
def get_messages( db: Session, thread_id: str, limit: int, order: str, after: str, before: str, ): # TODO: before and after work in a strange way query = db.query(models.Message).filter( models.Message.thread_id == thread_id ) if order == "asc": query = query.order_by( asc(models.Message.created_at), asc(models.Message.id) ) else: query = query.order_by( desc(models.Message.created_at), desc(models.Message.id) ) if after: last_seen_message = ( db.query(models.Message).filter(models.Message.id == after).first() ) if last_seen_message: query = query.filter( models.Message.created_at >= last_seen_message.created_at ) if before: first_seen_message = ( db.query(models.Message) .filter(models.Message.id == before) .first() ) if first_seen_message: query = query.filter( models.Message.created_at <= first_seen_message.created_at ) return query.limit(limit).all()
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Several endpoints using
SyncCursorPage
have a implementation forbefore
andafter
that don't make sense given the currentid
generation.Example:
The text was updated successfully, but these errors were encountered: