Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification notes #5

Open
Evolution0 opened this issue Oct 19, 2023 · 0 comments
Open

Specification notes #5

Evolution0 opened this issue Oct 19, 2023 · 0 comments
Assignees

Comments

@Evolution0
Copy link

The XML part of the spec could use a note that you cannot batch add Item nodes to the XML as intuitive as it feels to do so (why can't we?), each must be in its own <add> tag

For example (from the spec, good):

<xml path="dlclist.xml">
	<add append="First" xpath="/SMandatoryPacksData/Paths">
		<Item>dlcpacks:\spFirstTestMod\</Item>
	</add>
	
	<add append="Last" xpath="/SMandatoryPacksData/Paths">
		<Item>dlcpacks:\spLastTestMod\</Item>
	</add>
	
	<add append="Before" xpath="/SMandatoryPacksData/Paths/Item[.='dlcpacks:/mpheist/']">
		<Item>dlcpacks:\spBeforeHeistTest\</Item>
	</add>
	
	<add append="After" xpath="/SMandatoryPacksData/Paths/Item[.='dlcpacks:/patchday21ng/']">
		<Item>dlcpacks:\spAfter21ngTest\</Item>
	</add>
</xml>

Bad:

<xml path="dlclist.xml">
	<add append="Last" xpath="/SMandatoryPacksData/Paths">
		<Item>dlcpacks:\spFirstTestMod\</Item>
                <Item>dlcpacks:\spSecondTestMod\</Item>
		<Item>dlcpacks:\spThirdTestMod\</Item>
                <Item>dlcpacks:\spFourthTestMod\</Item>
	</add>
</xml>

This was a disappointing discovery, it really inflates the line count of the assembly file.

@GooD-NTS GooD-NTS self-assigned this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants