feat!: Implement FEATURE_BUNDLE_1 RFC 0004

I used the following prompt for LLM evaluation of this code change
against RFC 0004 in openjd-specifications:

> You are a helpful RFC conformance reviewer. Another agent has
> implemented RFC 0004, along with tests, in the most recent commit. Your
> job is to carefully inspect the RFC, the RFC-specific details in the
> OpenJD spec, and look at all the code changes to evaluate compliance.
> Produce a report on the quality of the implementation. How well does it
> conform? Give each relevant section/subsection of the spec a score. Also
> look at the unit tests and evaluate that it is covering all edge cases
> of the spec. Write your report to the file CONFORMANCE_REPORT.md.

All code also reviewed by hand.

BREAKING CHANGE: The types of some model class fields are extended from
    Optional[int] to Optional[int | FormatString], so downstream code
    that relies on those types can fail type checking.

Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>

Author: mwiebe

src/openjd/model/_internal/_create_job.py

@@ -92,6 +92,10 @@ def instantiate_model(  # noqa: C901
     errors = list[InitErrorDetails]()
     instantiated_fields = dict[str, Any]()
 
+    # Apply pre-transform if defined
+    if model._job_creation_metadata.transform is not None:
+        model = model._job_creation_metadata.transform(model)
+
     # Determine the target model to create as
     target_model = model.__class__
     if model._job_creation_metadata.create_as is not None:

src/openjd/model/_internal/_validator_functions.py

@@ -14,7 +14,7 @@ def validate_int_fmtstring_field(
     ge: Optional[int] = None,
     *,
     context: Optional[ModelParsingContextInterface],
-) -> Union[int, float, Decimal, FormatString]:
+) -> Union[int, FormatString]:
     """Validates a field that is allowed to be either an integer, a string containing an integer,
     or a string containing expressions that resolve to an integer."""
     value_type_wrong_msg = "Value must be an integer or a string containing an integer."
@@ -57,7 +57,7 @@ def validate_float_fmtstring_field(
     ge: Optional[Decimal] = None,
     *,
     context: Optional[ModelParsingContextInterface],
-) -> Union[int, float, Decimal, FormatString]:
+) -> Union[Decimal, FormatString]:
     """Validates a field that is allowed to be either an float, a string containing an float,
     or a string containing expressions that resolve to a float."""
     value_type_wrong_msg = "Value must be a float or a string containing a float."

src/openjd/model/_types.py

@@ -268,6 +268,13 @@ class JobCreationMetadata:
     """This instructs the instantiation code to rename the given fields.
     """
 
+    transform: Optional[Callable[["OpenJDModel"], "OpenJDModel"]] = field(default=None)
+    """A callable that transforms the source model before field processing.
+        arg0 - The model to transform.
+        returns - The transformed model (can be the same instance or a new one).
+        Use-case: Resolving syntax sugar on StepTemplate before creating Step.
+    """
+
 
 class OpenJDModel(BaseModel):
     model_config = ConfigDict(extra="forbid", frozen=True)

src/openjd/model/v2023_09/__init__.py

@@ -29,6 +29,7 @@
     EmbeddedFiles,
     EmbeddedFileText,
     EmbeddedFileTypes,
+    EndOfLine,
     Environment,
     EnvironmentActions,
     EnvironmentName,
@@ -64,6 +65,8 @@
     PathTaskParameterDefinition,
     RangeExpressionTaskParameterDefinition,
     RangeListTaskParameterDefinition,
+    ScriptInterpreter,
+    SimpleAction,
     Step,
     StepActions,
     StepEnvironmentList,
@@ -113,6 +116,7 @@
     "EmbeddedFiles",
     "EmbeddedFileText",
     "EmbeddedFileTypes",
+    "EndOfLine",
     "Environment",
     "EnvironmentActions",
     "EnvironmentScript",
@@ -148,6 +152,8 @@
     "PathTaskParameterDefinition",
     "RangeExpressionTaskParameterDefinition",
     "RangeListTaskParameterDefinition",
+    "ScriptInterpreter",
+    "SimpleAction",
     "Step",
     "StepActions",
     "StepEnvironmentList",