Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client should check the ven_id in _on_event #146

Open
juantxorena opened this issue Nov 28, 2022 · 1 comment
Open

Client should check the ven_id in _on_event #146

juantxorena opened this issue Nov 28, 2022 · 1 comment
Labels
bug Something isn't working Non-compliant behavior

Comments

@juantxorena
Copy link

IMHO the default implementation of _on_event should check if the venID of the received event matches the one of the client, and optOut the event if it doesn't. This can be done on the user's implementation of on_event, but I don't see any use case where this check doesn't make sense.

@juantxorena
Copy link
Author

juantxorena commented Nov 28, 2022

In addition, when this happens, it should respond with a 462 response code. It looks like the _on_event method only responds with 200, which is wrong.

Actually the VEN should respond with a 462 also when the resourceID doesn't match. This can only be done in the on_event implementation, but AFAIK it will always answer with a 200, so we should have the option of choosing which response to use for each event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Non-compliant behavior
Projects
None yet
Development

No branches or pull requests

2 participants