You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, most of the dependencies specified in setup.py aren't pinned. For example, if Jinja2 releases a major version then this package might break for anyone who hasn't pinned that themselves.
It would be good to pin each dependency to the current major version. For Jinja2, it would be nice to support 2.x as well as 3.x as the former is still widely used.
(I'd consider raising a PR for this myself.)
The text was updated successfully, but these errors were encountered:
Thanks. I pinned the releases to the current versions up to and excluding the next major version. I tried with the jinja2 2.X version (2.11.3), but that currently fails the integration tests.
If you'd like to add fixes to OpenLEADR to support jinja2 version 2.X, you're welcome to do so and I'll look at your pull request!
Currently, most of the dependencies specified in
setup.py
aren't pinned. For example, if Jinja2 releases a major version then this package might break for anyone who hasn't pinned that themselves.It would be good to pin each dependency to the current major version. For Jinja2, it would be nice to support 2.x as well as 3.x as the former is still widely used.
(I'd consider raising a PR for this myself.)
The text was updated successfully, but these errors were encountered: