Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies aren't pinned #151

Open
allanlewis opened this issue Feb 9, 2023 · 3 comments
Open

Dependencies aren't pinned #151

allanlewis opened this issue Feb 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@allanlewis
Copy link

Currently, most of the dependencies specified in setup.py aren't pinned. For example, if Jinja2 releases a major version then this package might break for anyone who hasn't pinned that themselves.

It would be good to pin each dependency to the current major version. For Jinja2, it would be nice to support 2.x as well as 3.x as the former is still widely used.

(I'd consider raising a PR for this myself.)

stan-janssen added a commit that referenced this issue Feb 9, 2023
This version adds pinned dependencies to the setup file.

Suggested in #151. Thanks!
@stan-janssen
Copy link
Member

Thanks. I pinned the releases to the current versions up to and excluding the next major version. I tried with the jinja2 2.X version (2.11.3), but that currently fails the integration tests.

If you'd like to add fixes to OpenLEADR to support jinja2 version 2.X, you're welcome to do so and I'll look at your pull request!

Thanks for the help and the interest!

@allanlewis
Copy link
Author

Hi @stan-janssen - would you have any objection if I migrated the metadata and dependency management to Poetry?

@stan-janssen
Copy link
Member

Sure, thanks. I left a comment on your draft pull request.

@axmsoftware axmsoftware added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants