Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dependency management to Poetry #152

Closed
wants to merge 4 commits into from

Conversation

allanlewis
Copy link

@allanlewis allanlewis commented Feb 9, 2023

This PR migrates the metadata and dependency management to pyproject.toml and Poetry.

This resolves #151.

.github/workflows/test-suite.yml Outdated Show resolved Hide resolved
@allanlewis
Copy link
Author

One thing I haven't checked is whether Poetry is including the files described in MANIFEST.in. I don't think it uses that file so we should probably delete it, but we might need to give Poetry some extra config to include those files; or it might just work.

@allanlewis allanlewis marked this pull request as ready for review February 21, 2023 14:58
@allanlewis
Copy link
Author

@stan-janssen Are you able to test this change? I don't know enough about the project to test it beyond what you've configured in CI; the latter needs approval to run.

@allanlewis
Copy link
Author

Is someone able to test this change?

@stan-janssen
Copy link
Member

@allanlewis sorry about not getting back to this earlier. I’ll be testing it this week, thanks!

Quote all numbers so they're treated, correctly, as strings.

Signed-off-by: Allan Lewis <[email protected]>
Signed-off-by: Allan Lewis <[email protected]>
Signed-off-by: Allan Lewis <[email protected]>
Signed-off-by: Allan Lewis <[email protected]>
@allanlewis
Copy link
Author

Rebased on main.

@allanlewis
Copy link
Author

@stan-janssen are you able to take a look at this?

@allanlewis
Copy link
Author

Closing for lack of interest.

@allanlewis allanlewis closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies aren't pinned
2 participants