Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element oadrSignedObject should not be included when XMLSignatures are disabled #153

Open
bpair opened this issue Apr 6, 2023 · 2 comments
Labels
wontfix This will not be worked on

Comments

@bpair
Copy link

bpair commented Apr 6, 2023

The VTN I am attempting to communicate with requires an X509 cert and TLS but not XML signatures. The messages are not signed but the payload contents are wrapped in an oadrSignedObject element which breaks the VTN. If there is no XML SIgnature then the oadrSignedObject should be removed.

@stan-janssen
Copy link
Member

That's a strange combination and I'm not sure that is really a part of the OpenADR specification. Which VTN are you trying to communicate with?

According to the OpenADR XML schema, all payloads are always wrapped in the oadrSignedObject tag:

<!-- Root element for all payloads -->
<xs:element name="oadrPayload">
<xs:complexType>
<xs:sequence>
<xs:element ref="ds:Signature" minOccurs="0"/>
<xs:element ref="oadr:oadrSignedObject"/>
</xs:sequence>
</xs:complexType>
</xs:element>

Is there documentation somewhere that says differently? Because then I will have to think about adjusting this.

@bpair
Copy link
Author

bpair commented Apr 6, 2023

I agree this is weird. I was trying to use code from https://github.com/avob/OpenADR The only thing in the spec is really about removing xml signatures to enable backward compatibility and it mentions removing the oadrSignedObject element. That would then not validate with the schema you reference. But then again why have a signedObject element wrap an unsigned element? I think I may have the XMLSignatures working in the avovb code after adding in some code to find the signed object element and attribute.

@axmsoftware axmsoftware added the wontfix This will not be worked on label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants