[BUG] ENV config override does not disable fields

[sreichel]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Setting config from ENV variable should lock the input field, but its not working for all.

Expected Behavior

All fields should be correctly disabled,

Steps To Reproduce

1. add to your .env

OPENMAGE_CONFIG_OVERRIDE_ALLOWED=1
OPENMAGE_CONFIG__DEFAULT__DEV__LOG__ACTIVE="1"
OPENMAGE_CONFIG__DEFAULT__DEV__LOG__MAX_LEVEL="0"
OPENMAGE_CONFIG__DEFAULT__DEV__LOG__FILE="env.system.log"
OPENMAGE_CONFIG__DEFAULT__DEV__LOG__EXCEPTION_FILE="env.exceptions.log"

2. go to admin - config - advanced - developer - log setting ...
3. all fields should be disabled

Environment

- OpenMage: latest
- php: 8.x

Anything else?

No response

[pquerner]

Cannot reproduce

.ddev/config.yml

web_environment:
    - MAGE_IS_DEVELOPER_MODE=1
    - OPENMAGE_CONFIG_OVERRIDE_ALLOWED=1
    - OPENMAGE_CONFIG__DEFAULT__DEV__LOG__ACTIVE=1

[sreichel]

@pquerner please test the other fields too.

"active" is fine, but all others?

Its strange, code looks fine, source code has disabled="disabled", but its removed?

(firefox)

[pquerner]

Ah, it doesnt work for the other fields. Interesting.

Seems like the "disabled" here is not for every input type
https://github.com/pquerner/magento-lts/blob/main/app/code/core/Mage/Adminhtml/Block/System/Config/Form.php#L413