From d65bc749f1ba73b31c2d1e76fddd38af18cd59ba Mon Sep 17 00:00:00 2001 From: khoaguin Date: Fri, 17 May 2024 09:59:23 +0700 Subject: [PATCH 1/2] [DX] print out SQLite database path in dev mode when launching python in memory nodes --- packages/syft/src/syft/node/node.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/syft/src/syft/node/node.py b/packages/syft/src/syft/node/node.py index 7861ee422e0..59acfee2f4b 100644 --- a/packages/syft/src/syft/node/node.py +++ b/packages/syft/src/syft/node/node.py @@ -437,9 +437,12 @@ def runs_in_docker(self) -> bool: def get_default_store(self, use_sqlite: bool) -> StoreConfig: if use_sqlite: path = self.get_temp_dir("db") + file_name: str = f"{self.id}.sqlite" + if self.dev_mode: + print(f"SQLite db path: {path/file_name}") return SQLiteStoreConfig( client_config=SQLiteStoreClientConfig( - filename=f"{self.id}.sqlite", + filename=file_name, path=path, ) ) From a10f4058a1659a247de7acb0b14c9513cfbc83b0 Mon Sep 17 00:00:00 2001 From: khoaguin Date: Tue, 21 May 2024 09:11:59 +0700 Subject: [PATCH 2/2] [DX] pass an argument to print out SQLite store type (document or action store) --- packages/syft/src/syft/node/node.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/syft/src/syft/node/node.py b/packages/syft/src/syft/node/node.py index 59acfee2f4b..34c10dd9efe 100644 --- a/packages/syft/src/syft/node/node.py +++ b/packages/syft/src/syft/node/node.py @@ -372,10 +372,12 @@ def __init__( use_sqlite = local_db or (processes > 0 and not is_subprocess) document_store_config = document_store_config or self.get_default_store( - use_sqlite=use_sqlite + use_sqlite=use_sqlite, + store_type="Document Store", ) action_store_config = action_store_config or self.get_default_store( - use_sqlite=use_sqlite + use_sqlite=use_sqlite, + store_type="Action Store", ) self.init_stores( action_store_config=action_store_config, @@ -434,12 +436,12 @@ def runs_in_docker(self) -> bool: and any("docker" in line for line in open(path)) ) - def get_default_store(self, use_sqlite: bool) -> StoreConfig: + def get_default_store(self, use_sqlite: bool, store_type: str) -> StoreConfig: if use_sqlite: path = self.get_temp_dir("db") file_name: str = f"{self.id}.sqlite" if self.dev_mode: - print(f"SQLite db path: {path/file_name}") + print(f"{store_type}'s SQLite DB path: {path/file_name}") return SQLiteStoreConfig( client_config=SQLiteStoreClientConfig( filename=file_name,