Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dettach disk or nic is disabled in regular users #6820

Open
3 tasks
dcarracedo opened this issue Dec 11, 2024 · 0 comments
Open
3 tasks

Dettach disk or nic is disabled in regular users #6820

dcarracedo opened this issue Dec 11, 2024 · 0 comments
Assignees

Comments

@dcarracedo
Copy link
Contributor

dcarracedo commented Dec 11, 2024

Description
A regular user cannot dettach disk or nic from a vm. They should be able to dettach any disk or nic from a vm:

image

To Reproduce

  1. Instantiate a vm as a regular user
  2. Attach a disk
  3. User cannot dettach the disk

Expected behavior

That an user can attach and dettach a disk or nic without restrictions, no matter if a restricted attribute exists.

Details

  • Affected Component: Sunstone
  • Hypervisor: N/A
  • Version: 6.10.0

** Additional context **

The previous behavior it's only for vm instances. For vm templates, we need to improve the checking with the following rules:

Iif the following restricted attributes exists in oned.conf:

VM_RESTRICTED_ATTR = "DISK/TOTAL_BYTES_SEC"

And the vm template has a value for this attribute (e.g. TOTAL_BYTES_SEC=20") the dettach option should be disabled. But if the vm template has not any value for this attribute (e.g. the attribute doesn't exist in the template) the dettach option should be enabled.

Same behavior in NIC, PCI and schedule actions.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@dcarracedo dcarracedo self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant