From c5e80073a23693feeaff89837a96dc7a2c9c273f Mon Sep 17 00:00:00 2001
From: romainvalls <romain.valls95@gmail.com>
Date: Thu, 27 Jun 2024 09:10:53 +0200
Subject: [PATCH] front: fix begin input

---
 .../IntervalsEditor/IntervalsEditor.tsx       |   7 +-
 .../IntervalsEditorCommonForm.tsx             |  15 ++-
 .../PowerRestrictionsSelectorV2.tsx           |  96 ++++++++++-----
 .../reducers/osrdconf/osrdConfCommon/index.ts | 114 +++++++++++++++++-
 4 files changed, 198 insertions(+), 34 deletions(-)

diff --git a/front/src/common/IntervalsEditor/IntervalsEditor.tsx b/front/src/common/IntervalsEditor/IntervalsEditor.tsx
index a73e66de136..253453b337b 100644
--- a/front/src/common/IntervalsEditor/IntervalsEditor.tsx
+++ b/front/src/common/IntervalsEditor/IntervalsEditor.tsx
@@ -52,7 +52,12 @@ type IntervalsEditorProps = {
   /** Total length of the path */
   totalLength: number;
   disableDrag?: boolean;
-  onResizeFromInput?: (intervalIndex: number, newEnd: number, context: 'begin' | 'end') => void;
+  onResizeFromInput?: (
+    intervalIndex: number,
+    newEnd: number,
+    context: 'begin' | 'end',
+    newBegin?: number
+  ) => void;
 } & (
   | {
       intervalType: INTERVAL_TYPES.NUMBER;
diff --git a/front/src/common/IntervalsEditor/IntervalsEditorCommonForm.tsx b/front/src/common/IntervalsEditor/IntervalsEditorCommonForm.tsx
index 0c374b4bc60..dd01a8f6951 100644
--- a/front/src/common/IntervalsEditor/IntervalsEditorCommonForm.tsx
+++ b/front/src/common/IntervalsEditor/IntervalsEditorCommonForm.tsx
@@ -13,7 +13,12 @@ type IntervalsEditorFormProps = {
   interval: IntervalItem;
   selectedIntervalIndex: number;
   setData: (newData: IntervalItem[], selectedIntervalIndex?: number) => void;
-  onInputChange?: (intervalIndex: number, newBegin: number, context: 'begin' | 'end') => void;
+  onInputChange?: (
+    intervalIndex: number,
+    newEnd: number,
+    context: 'begin' | 'end',
+    newBegin: number
+  ) => void;
   setSelectedIntervalIndex: (selectedIntervalIndex: number) => void;
   totalLength: number;
   defaultValue: string | number;
@@ -41,6 +46,7 @@ const IntervalsEditorCommonForm = ({
 
   const resizeSegmentByInput = (newPosition: number, context: 'begin' | 'end') => {
     const gap = newPosition - interval[context];
+
     // use absolute value to manage cases where the position is not rounded
     // ex: begin = 1200.68 and newPosition = 1200 (because input is rounded)
     if (Math.abs(gap) > 1) {
@@ -56,7 +62,12 @@ const IntervalsEditorCommonForm = ({
         defaultValue,
       });
       if (onInputChange) {
-        onInputChange(selectedIntervalIndex, newPosition, context);
+        onInputChange(
+          selectedIntervalIndex,
+          context === 'end' ? newPosition : interval.end,
+          context,
+          context === 'begin' ? newPosition : interval.begin
+        ); // Pass newBegin when context is 'begin'
       } else {
         setData(fixedResults, selectedIntervalIndex);
       }
diff --git a/front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx b/front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
index 4886d6f9c95..15c6e9a9d3c 100644
--- a/front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
+++ b/front/src/modules/powerRestriction/components/PowerRestrictionsSelectorV2.tsx
@@ -46,7 +46,8 @@ const PowerRestrictionsSelectorV2 = ({
     resetPowerRestrictionRangesV2,
     cutPowerRestrictionRangesV2,
     deletePowerRestrictionRangesV2,
-    resizePowerRestrictionRangeV2,
+    resizeSegmentEndInput,
+    resizeSegmentBeginInput,
   } = useOsrdConfActions();
   const powerRestrictionRanges = useSelector(getPowerRestrictionV2);
   const pathSteps = compact(useSelector(getPathSteps));
@@ -199,49 +200,86 @@ const PowerRestrictionsSelectorV2 = ({
     }
   };
 
-  const resizeSegmentByInput = (
+  const resizeSegments = (
     selectedSegmentIndex: number,
     newEnd: number,
-    context: 'begin' | 'end'
+    context: 'begin' | 'end',
+    newBegin?: number
   ) => {
-    const firstIndex = context === 'end' ? selectedSegmentIndex : selectedSegmentIndex - 1;
+    const firstIndex = context === 'end' ? selectedSegmentIndex : selectedSegmentIndex;
+
+    const getPathStep = (position: number) =>
+      pathSteps.find((step) => step.positionOnPath === position);
+
+    const getPowerRestriction = (begin: number, end: number): PowerRestrictionV2 | undefined => {
+      const fromPathStep = getPathStep(begin);
+      const toPathStep = getPathStep(end);
+
+      if (fromPathStep && toPathStep) {
+        return powerRestrictionRanges.find(
+          (restriction) => restriction.from === fromPathStep.id && restriction.to === toPathStep.id
+        );
+      }
+      return undefined; // Ensure a value is always returned
+    };
 
     let firstRestriction: PowerRestrictionV2 | undefined;
     let secondRestriction: PowerRestrictionV2 | undefined;
+    let previousRestriction: PowerRestrictionV2 | undefined;
+
     if (firstIndex >= 0) {
       const firstRangeData = intervalsEditorData[firstIndex];
       if (firstRangeData.value !== NO_POWER_RESTRICTION) {
-        const fromPathStep = pathSteps.find((step) => step.positionOnPath === firstRangeData.begin);
-        const toPathStep = pathSteps.find((step) => step.positionOnPath === firstRangeData.end);
-        if (fromPathStep && toPathStep) {
-          firstRestriction = powerRestrictionRanges.find(
-            (restriction) =>
-              restriction.from === fromPathStep.id && restriction.to === toPathStep.id
-          );
-        }
+        firstRestriction = getPowerRestriction(firstRangeData.begin, firstRangeData.end);
       }
     }
 
-    const secondRangeData = intervalsEditorData[firstIndex + 1];
-    if (secondRangeData.value !== NO_POWER_RESTRICTION) {
-      const fromPathStep = pathSteps.find((step) => step.positionOnPath === secondRangeData.begin);
-      const toPathStep = pathSteps.find((step) => step.positionOnPath === secondRangeData.end);
-      if (fromPathStep && toPathStep) {
-        secondRestriction = powerRestrictionRanges.find(
-          (restriction) => restriction.from === fromPathStep.id && restriction.to === toPathStep.id
-        );
+    if (context === 'end') {
+      const secondRangeData = intervalsEditorData[firstIndex + 1];
+      if (secondRangeData.value !== NO_POWER_RESTRICTION) {
+        secondRestriction = getPowerRestriction(secondRangeData.begin, secondRangeData.end);
+      }
+
+      let newEndPathStep = getPathStep(newEnd);
+      if (!newEndPathStep) {
+        newEndPathStep = createPathStep(newEnd, cumulativeSums, pathProperties, pathSteps);
       }
-    }
 
-    let newEndPathStep = pathSteps.find((pathStep) => pathStep.positionOnPath === newEnd);
-    if (!newEndPathStep) {
-      newEndPathStep = createPathStep(newEnd, cumulativeSums, pathProperties, pathSteps);
+      if (firstRestriction && newEndPathStep) {
+        dispatch(
+          resizeSegmentEndInput({
+            firstRestriction,
+            secondRestriction,
+            newEndPathStep,
+          })
+        );
+      }
     }
+    if (context === 'begin') {
+      if (firstIndex > 0) {
+        const previousRangeData = intervalsEditorData[firstIndex - 1];
+        if (previousRangeData.value) {
+          previousRestriction = getPowerRestriction(previousRangeData.begin, previousRangeData.end);
+        } else {
+          return;
+        }
+      }
 
-    if (firstRestriction && newEndPathStep) {
-      dispatch(
-        resizePowerRestrictionRangeV2({ firstRestriction, secondRestriction, newEndPathStep })
-      );
+      if (newBegin) {
+        let newFromPathStep = getPathStep(newBegin);
+        if (!newFromPathStep) {
+          newFromPathStep = createPathStep(newBegin, cumulativeSums, pathProperties, pathSteps);
+          if (firstRestriction && newFromPathStep) {
+            dispatch(
+              resizeSegmentBeginInput({
+                firstRestriction,
+                previousRestriction,
+                newFromPathStep,
+              })
+            );
+          }
+        }
+      }
     }
   };
 
@@ -371,7 +409,7 @@ const PowerRestrictionsSelectorV2 = ({
                 deleteTool: true,
               }}
               disableDrag
-              onResizeFromInput={resizeSegmentByInput}
+              onResizeFromInput={resizeSegments}
             />
             <button
               className="btn-link text-reset"
diff --git a/front/src/reducers/osrdconf/osrdConfCommon/index.ts b/front/src/reducers/osrdconf/osrdConfCommon/index.ts
index 119342b3f63..f5d87fb5104 100644
--- a/front/src/reducers/osrdconf/osrdConfCommon/index.ts
+++ b/front/src/reducers/osrdconf/osrdConfCommon/index.ts
@@ -124,7 +124,7 @@ interface CommonConfReducers<S extends OsrdConfState> extends InfraStateReducers
     S,
     PayloadAction<{ from: PathStep; to: PathStep }>
   >;
-  ['resizePowerRestrictionRangeV2']: CaseReducer<
+  ['resizeSegmentEndInput']: CaseReducer<
     S,
     PayloadAction<{
       firstRestriction: PowerRestrictionV2;
@@ -132,6 +132,14 @@ interface CommonConfReducers<S extends OsrdConfState> extends InfraStateReducers
       newEndPathStep: PathStep;
     }>
   >;
+  ['resizeSegmentBeginInput']: CaseReducer<
+    S,
+    PayloadAction<{
+      firstRestriction: PowerRestrictionV2;
+      previousRestriction?: PowerRestrictionV2;
+      newFromPathStep: PathStep;
+    }>
+  >;
   ['resetPowerRestrictionRangesV2']: CaseReducer<S>;
   ['updateTrainScheduleIDsToModify']: CaseReducer<S, PayloadAction<S['trainScheduleIDsToModify']>>;
   ['updateFeatureInfoClick']: CaseReducer<S, PayloadAction<S['featureInfoClick']>>;
@@ -490,7 +498,7 @@ export function buildCommonConfReducers<S extends OsrdConfState>(): CommonConfRe
       state.pathSteps = newPathSteps;
       state.powerRestrictionV2 = newPowerRestrictionRangesV2;
     },
-    resizePowerRestrictionRangeV2(
+    resizeSegmentEndInput(
       state: Draft<S>,
       action: PayloadAction<{
         firstRestriction: PowerRestrictionV2;
@@ -612,6 +620,108 @@ export function buildCommonConfReducers<S extends OsrdConfState>(): CommonConfRe
       state.pathSteps = newPathSteps;
       state.powerRestrictionV2 = newPowerRestrictionRanges;
     },
+    resizeSegmentBeginInput(
+      state: Draft<S>,
+      action: PayloadAction<{
+        firstRestriction: PowerRestrictionV2;
+        previousRestriction?: PowerRestrictionV2;
+        newFromPathStep: PathStep;
+      }>
+    ) {
+      const { firstRestriction, previousRestriction, newFromPathStep } = action.payload;
+      let newPathSteps = [...state.pathSteps];
+      let newPowerRestrictionRanges = state.powerRestrictionV2.filter(
+        (restriction) =>
+          !isEqual(restriction, firstRestriction) || !isEqual(restriction, previousRestriction)
+      );
+
+      // Remove the previous from pathStep of the first restriction if needed
+      const oldPathStepBeginId = firstRestriction.from;
+      const oldPathStepBegin = newPathSteps.find(
+        (pathStep) => pathStep && pathStep.id === oldPathStepBeginId
+      );
+      if (oldPathStepBegin) {
+        const oldPathStepBeginIsUsed = newPowerRestrictionRanges.some(
+          (restriction) =>
+            restriction.from === oldPathStepBeginId || restriction.to === oldPathStepBeginId
+        );
+        if (oldPathStepBeginIsUsed && checkValidPathStep(oldPathStepBegin)) {
+          newPathSteps = newPathSteps.filter(
+            (pathStep) => pathStep?.positionOnPath !== oldPathStepBegin.positionOnPath
+          );
+        }
+      }
+
+      // Create the new from pathStep if it does not exist
+      const newFromPathStepExists = newPathSteps.some(
+        (pathStep) => pathStep && pathStep.id === newFromPathStep.id
+      );
+      if (!newFromPathStepExists) {
+        const index = newPathSteps.findIndex(
+          (step) => step?.positionOnPath && step.positionOnPath > newFromPathStep.positionOnPath!
+        );
+
+        newPathSteps = addElementAtIndex(newPathSteps, index, newFromPathStep);
+      }
+
+      // Update the powerRestrictions
+      newPowerRestrictionRanges = newPowerRestrictionRanges.map((restriction) => {
+        if (restriction.from === firstRestriction.from) {
+          return { ...restriction, from: newFromPathStep.id };
+        }
+        if (restriction.from === previousRestriction?.from) {
+          return { ...restriction, from: newFromPathStep.id };
+        }
+        return restriction;
+      });
+
+      // Remove ranges that are completely covered
+      if (previousRestriction) {
+        const previousRestrictionToPathStep = newPathSteps.find(
+          (pathStep) => pathStep && pathStep.id === previousRestriction.to
+        );
+        if (previousRestrictionToPathStep) {
+          const isRangeCovered = (range: PowerRestrictionV2) => {
+            const fromPathStep = newPathSteps.find(
+              (pathStep) => pathStep && pathStep.id === range.from
+            );
+            const toPathStep = newPathSteps.find(
+              (pathStep) => pathStep && pathStep.id === range.to
+            );
+
+            if (
+              fromPathStep?.positionOnPath === undefined ||
+              toPathStep?.positionOnPath === undefined
+            ) {
+              return false;
+            }
+            return (
+              fromPathStep?.positionOnPath <= newFromPathStep.positionOnPath! &&
+              fromPathStep?.positionOnPath >= previousRestrictionToPathStep.positionOnPath!
+            );
+          };
+          newPowerRestrictionRanges = newPowerRestrictionRanges.filter(
+            (restriction) => !isRangeCovered(restriction)
+          );
+        }
+        if (previousRestrictionToPathStep) {
+          const previousRestrictionToPathStepIsUsed = newPowerRestrictionRanges.some(
+            (restriction) =>
+              restriction.from === previousRestrictionToPathStep.id ||
+              restriction.to === previousRestrictionToPathStep.id
+          );
+          if (!previousRestrictionToPathStepIsUsed && newPathSteps) {
+            newPathSteps = newPathSteps.filter(
+              (pathStep) => pathStep && pathStep.id !== previousRestrictionToPathStep!.id
+            );
+          }
+        }
+      }
+
+      state.pathSteps = newPathSteps;
+      state.powerRestrictionV2 = newPowerRestrictionRanges;
+    },
+
     // TODO Remove this
     resetPowerRestrictionRangesV2(state: Draft<S>) {
       state.powerRestrictionV2 = [];