Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmr: Information message under error message is not centered #10135

Closed
maelysLeratRosso opened this issue Dec 19, 2024 · 6 comments · Fixed by #10272
Closed

lmr: Information message under error message is not centered #10135

maelysLeratRosso opened this issue Dec 19, 2024 · 6 comments · Fixed by #10272
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug

Comments

@maelysLeratRosso
Copy link

maelysLeratRosso commented Dec 19, 2024

What happened?

When there is a technical problem, I get this

Image

What did you expect to happen?

It should look like this (ignore the blue arrow, it is for another bug)
Image

So :

  • The text below should be centered

How can we reproduce it (as minimally and precisely as possible)?

Create a very long train to get the error and observe

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Google Chrome

OSRD version (top right corner Account button > Informations)

6580cfe

@maelysLeratRosso maelysLeratRosso added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug module:stdcm Short-Term DCM labels Dec 19, 2024
@SharglutDev
Copy link
Contributor

For the centering it's definitely a bug but for the position, the red square is attached a the edge between the "config" and "result" part (backgrounds are a bit different) and I think that's the wanted behavior from @thibautsailly. Maybe you should discuss it with him :)

@thibautsailly
Copy link

Could you specify the viewport size and the amount of intermediate OPs you had when you witnessed this?
It seems to me you had a tall browser window and a short form, and if this is the case mediaqueries will be ideal to fix this.

@maelysLeratRosso
Copy link
Author

maelysLeratRosso commented Jan 7, 2025

Here is a full screen screenshot:
Image

I have no intermediate OP
It is a tall window (resolution 1920*1080)
Zoom 80% on chrome

@sim51
Copy link
Contributor

sim51 commented Jan 7, 2025

This is what I have with a screen of 1920x1080 :

Screenshot of the full page :
Image

Only the visible part
Image

Note: on this screen I don't clearly see errors & warnings because they are "displayed" bellow my screen.

sim51 added a commit that referenced this issue Jan 7, 2025
sim51 added a commit that referenced this issue Jan 7, 2025
sim51 added a commit that referenced this issue Jan 7, 2025
sim51 added a commit that referenced this issue Jan 7, 2025
sim51 added a commit that referenced this issue Jan 7, 2025
@SharglutDev
Copy link
Contributor

SharglutDev commented Jan 7, 2025

As this ticket concerns 2 issues, we gonna merge the fix for the centering while a eventual solution is found for the other part. If there is, @maelysLeratRosso would you be so kind to open a new ticket ? :)

@maelysLeratRosso
Copy link
Author

I opened this bug for the spacing part (this one is now only centering)

@maelysLeratRosso maelysLeratRosso changed the title lmr: Weird position of the error message lmr: Information message under error message is not centered Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants