Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: technical debt pathfinding component #7918

Open
anisometropie opened this issue Jul 2, 2024 · 0 comments
Open

front: technical debt pathfinding component #7918

anisometropie opened this issue Jul 2, 2024 · 0 comments
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features

Comments

@anisometropie
Copy link
Contributor

anisometropie commented Jul 2, 2024

Description and goal

in ManageTrainScheduleV2, some major transformation on pathfinding data is delegated to sub components TypeAndPathV2.

launchPathFinding has much more responsibility than a mere (and small) subcomponent should have

I think that’s a design flaw and a case where props drilling is problematic. it creates major indirection: difficult to follow where to data comes from and what’s done to it.

This really could be a proper case to use a business hook (as proposed by @jacomyal @sim51)
to be discussed

@clarani clarani added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules labels Jul 2, 2024
@clarani clarani changed the title Technical debt pathfinding component front: technical debt pathfinding component Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants