Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: editor: enable to select switch for speed restriction by routes #7946

Closed
bloussou opened this issue Jul 4, 2024 · 0 comments · Fixed by #7952
Closed

front: editor: enable to select switch for speed restriction by routes #7946

bloussou opened this issue Jul 4, 2024 · 0 comments · Fixed by #7952
Assignees
@jacomyal
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug

Comments

@bloussou
Copy link
Contributor

bloussou commented Jul 4, 2024

What happened?

See:

Enregistrement.de.l.ecran.2024-07-04.a.14.23.03.mov

What did you expect to happen?

No response

How can we reproduce it (as minimally and precisely as possible)?

See the video

What operating system, browser and environment are you using?

  • Browser: Firefox

OSRD version (top right corner Account button > Informations)

staging dc11fc8
@bloussou bloussou added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:critical Critical severity bug module:infra-editor Infra Edition labels Jul 4, 2024
@bloussou bloussou changed the title editor: enable to select switch for speed restriction by routes front: editor: enable to select switch for speed restriction by routes Jul 4, 2024
jacomyal added a commit that referenced this issue Jul 4, 2024
@jacomyal
editor: improves switch types cache handling
4f730ef 
This commit fixes #7946.

Details:
- Adds a `?` to handle case where switch types have not been loaded yet
  in SwitchList.tsx
- Adds a very simple cache to useSwitchTypes to avoid reloading switch
  types any time a new component mounts with that hook
@jacomyal jacomyal mentioned this issue Jul 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 8, 2024
@jacomyal @clarani
editor: improves switch types cache handling
4dfa713 
This commit fixes #7946.

Details:
- Adds a `?` to handle case where switch types have not been loaded yet
  in SwitchList.tsx
- Adds a very simple cache to useSwitchTypes to avoid reloading switch
  types any time a new component mounts with that hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacomyal jacomyal

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: improves switch types cache handling OpenRailAssociation/osrd
2 participants
@jacomyal @bloussou