Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop _ from non private methods #94

Open
abhayks1 opened this issue Feb 15, 2019 · 3 comments
Open

Drop _ from non private methods #94

abhayks1 opened this issue Feb 15, 2019 · 3 comments

Comments

@abhayks1
Copy link
Contributor

No description provided.

@abhayks1 abhayks1 removed the v0.10.0 label Mar 14, 2019
@schemar
Copy link
Contributor

schemar commented Apr 15, 2019

Is it ok to break the interface here and should this then not be part of 0.10?

@benjaminbollen
Copy link
Contributor

is ok to break on develop v0.11

@schemar
Copy link
Contributor

schemar commented Apr 29, 2019

is this still required if we move to auto-generated contract interacts @benjaminbollen. We probably need to properly rewrite all JS layers anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schemar @benjaminbollen @abhayks1