Bug description
Request-signature emails can use the owner's profile name in the from field even when the document already has an explicit SenderName.
Why this happens
In sendEmailToSigners, the from value is computed with an expression that mixes || and the ternary operator without grouping. In JavaScript, that means the condition is evaluated as (SenderName || useNameAsSender), so any truthy SenderName still routes to ExtUserPtr.Name instead of preserving the explicit sender name.
Expected behavior
If SenderName is set on the document, the outgoing request email should use that exact value in the from field.
Actual behavior
When both SenderName and ExtUserPtr.Name exist, the email can be sent with ExtUserPtr.Name as the display name.
Reproduction idea
- Create a document where
SenderName is set to a value different from the owner's profile name.
- Send a signature request email.
- Inspect the outgoing email
from display name.
- Observe that it uses the owner profile name instead of the explicit
SenderName.
Impact
This can make request emails display the wrong sender identity, which is confusing for recipients and breaks expected mail customization.
Bug description
Request-signature emails can use the owner's profile name in the
fromfield even when the document already has an explicitSenderName.Why this happens
In
sendEmailToSigners, thefromvalue is computed with an expression that mixes||and the ternary operator without grouping. In JavaScript, that means the condition is evaluated as(SenderName || useNameAsSender), so any truthySenderNamestill routes toExtUserPtr.Nameinstead of preserving the explicit sender name.Expected behavior
If
SenderNameis set on the document, the outgoing request email should use that exact value in thefromfield.Actual behavior
When both
SenderNameandExtUserPtr.Nameexist, the email can be sent withExtUserPtr.Nameas the display name.Reproduction idea
SenderNameis set to a value different from the owner's profile name.fromdisplay name.SenderName.Impact
This can make request emails display the wrong sender identity, which is confusing for recipients and breaks expected mail customization.