Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/clean versions #24

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Feature/clean versions #24

merged 4 commits into from
Apr 25, 2023

Conversation

eliegaboriau
Copy link
Contributor

@eliegaboriau eliegaboriau commented Apr 12, 2023 •
edited
Loading

🎩 Description

Please describe your pull request.

This PR adds a new feature to the module.
It can now delete versions related to deleted users or deleted authorizations.
It can be configured in the .ENV

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Find in db the version of a user and an authorization
  • Revoke the authorizations and delete the user
  • run the rake task
  • See the versions have disappeared

Tasks

  • Add specs

@eliegaboriau eliegaboriau marked this pull request as ready for review April 12, 2023 14:07
@eliegaboriau eliegaboriau linked an issue Apr 12, 2023 that may be closed by this pull request
Versioned personal data stored by PaperTrail left behind #11
Open
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.38 🎉

Comparison is base (40f20fb) 86.30% compared to head (44d0ea1) 89.69%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    86.30%   89.69%   +3.38%     
===========================================
  Files           12       14       +2     
  Lines          146      194      +48     
===========================================
+ Hits           126      174      +48     
  Misses          20       20
Impacted Files Coverage Δ
app/helpers/decidim/cleaner/delays_helper.rb 100.00% <100.00%> (ø)
app/jobs/decidim/cleaner/clean_admin_logs_job.rb 100.00% <100.00%> (ø)
...bs/decidim/cleaner/clean_deleted_users_data_job.rb 100.00% <100.00%> (ø)
...p/jobs/decidim/cleaner/clean_inactive_users_job.rb 100.00% <100.00%> (ø)
...p/mailers/decidim/cleaner/inactive_users_mailer.rb 100.00% <100.00%> (ø)
lib/decidim/cleaner.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Quentinchampenois
Quentinchampenois approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Quentinchampenois Quentinchampenois merged commit d3b7ee7 into develop Apr 25, 2023
@Quentinchampenois Quentinchampenois deleted the feature/clean_versions branch April 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

@armandfardeau armandfardeau armandfardeau approved these changes

@paulinebessoles paulinebessoles Awaiting requested review from paulinebessoles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioned personal data stored by PaperTrail left behind
3 participants
@eliegaboriau @armandfardeau @Quentinchampenois