Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the translations #37

Open
ahukkanen opened this issue Aug 4, 2023 · 0 comments
Open

Improving the translations #37

ahukkanen opened this issue Aug 4, 2023 · 0 comments

Comments

@ahukkanen
Copy link
Contributor

ahukkanen commented Aug 4, 2023

I just contributed the Finnish translations (see #36).

During this process, I noticed some things that we could improve with the source translations (English):

Key Original string (en) Suggestion
activemodel.attributes.organization.delete_admin_logs_after Delete admin logs after (days, default 365) Admin logs retention period (days, default 365)
activemodel.attributes.organization.delete_inactive_users_after Delete inactive users x days after the mail (days, default 30) Inactive users retention period after the warning message (days, default 30)
activemodel.attributes.organization.delete_inactive_users_email_after Send email to inactive users before deletion (days, default 365) User account inactivity period before warning them about account deletion (days, default 365)
decidim.cleaner.inactive_users_mailer.warning_deletion.body_1 You are inactive since %{days} days on <a href="%{organization_url}">%{organization_name}</a>. You have been inactive for %{days} days on <a href="%{organization_url}">%{organization_name}</a>.
decidim.cleaner.inactive_users_mailer.warning_inactive.body_1 You are inactive since %{days} days on %{organization_name}. You have been inactive for %{days} days on %{organization_name}.
decidim.cleaner.inactive_users_mailer.warning_inactive.body_2 <a href="%{organization_url}">If no reaction within %{remaining_days} days</a>, your account will be deleted. If you do not <a href="%{organization_url}">sign in again within %{remaining_days} days </a>, your account will be deleted.
decidim.cleaner.inactive_users_mailer.warning_inactive.subject Your account is inactive Your account has been inactive for a long time at %{organization_name}

Note that in the suggestions I am also suggesting to add the organization name as an interpolation to the email subjects which would also require changing the code where the subject is generated.


Few other suggestions that came to my mind:

  • Changing the URL of the warning email to point to the sign in page if sign in is enabled on the platform
    • If sign in is not enabled link to the organization URL as currently
  • Adding a bit of explanation to the inactivity warning email why the account is being deleted (see below)
  • Adding a bit of explanation to the account deletion email why the account was deleted (see below)

For the explanations, I would suggest the following:

Warning message before the deletion of the data

We regularly delete inactive user accounts on %{organization_name} to ensure that we are not storing unnecessary personal data in our databases. If you want to retain your data, you can sign in and download it from your account pages. You also have the possibility to delete the account yourself from the account pages.

If you do not react to this message, your account and personal details will be automatically deleted from the platform. Your earlier contributions will remain on the platform anonymized even if your account is deleted.

Message after deletion

We regularly delete inactive user accounts on %{organization_name} to ensure that we are not storing unnecessary personal data in our databases. If you have any questions, please contact us using the contact details available at <a href="%{organization_url}">the platform</a>.

Thank you for being part of %{organization_name}. We truly appreciate your contributions and hope to see you soon again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant