Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo #606

Open
nivelus opened this issue Sep 18, 2024 · 4 comments
Open

Typo #606

nivelus opened this issue Sep 18, 2024 · 4 comments

Comments

@nivelus
Copy link

nivelus commented Sep 18, 2024

Describe the bug

./src/openvpn/ssl.c:4109: "Be aware that that whether a cipher suite in this list can actually work\n"

I believe there is typo: one extra 'that'. Or missing comma between thats.

@nivelus
Copy link
Author

nivelus commented Sep 20, 2024

Hey? does anyone here? What is usual response time?

@cron2
Copy link
Contributor

cron2 commented Sep 20, 2024

Since this is run by unpaid volunteers, response time can vary between "5 minutes" and "never"...

Thanks for uncovering that typo. Now someone needs to actually code a patch and send it to the list or to gerrit for review and merging.

@nivelus
Copy link
Author

nivelus commented Sep 20, 2024

Thanks for reply, it is very simple patch, but i don't quite understand why it needed. Because construction "that that" is quite common, i will be glad to see some explanation for this particular case. Then I can make patch if it is really just a typo.

@ordex
Copy link
Member

ordex commented Sep 25, 2024

@nivelus by looking at the whole paragraph, it seems like there is an extra 'that'.

mohitkr827 added a commit to mohitkr827/openvpn that referenced this issue Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants