CoP from GoG: Missing gamedata\scripts\actor_menu_inventory.script

[plaes]

Describe the bug

Seems like CoP extracted from GoG installer (v2.1.0.17) is missing a script: gamedata\scripts\actor_menu_inventory.script:

! [LUA]  Cannot open file "...\GSC Game World\S.T.A.L.K.E.R. - Call of Pripyat\gamedata\scripts\actor_menu_inventory.script"
stack traceback:

Script is referenced from source code (added in pull #1030):

xray-16/src/xrGame/ui/UIActorMenu_action.cpp

Line 77 in ec2263a

if (GEnv.ScriptEngine->functor("actor_menu_inventory.CUIActorMenu_OnItemDropped", funct1))

Desktop (please complete the following information):

• OS: Fedora 41
• OpenXRay dev branch HEAD (commit ec2263a)

[Xottab-DUTY]

This is not original game file, it's optional and can be added by modmakers to enhance gameplay functionality.

But the fact that it can confuse people due to a log message is a problem, though.

[alsed]

Asuming that all optional files are located in "/gamedata/" , a search for it in cfg_full_name could print a specific message.
This will inform any problem with an optional script.

https://github.com/OpenXRay/xray-16/blob/dev/src/xrEngine/xr_ioc_cmd.cpp#L221

    string1024 str;
    if (F != nullptr)
    {
        while (!F->eof())
        {
            F->r_string(str, sizeof(str));
            if (allow(str))
                Console->Execute(str);
        }
        FS.r_close(F);
        Msg("[%s] successfully loaded.", cfg_full_name);
    }
    else if (cfg_full_name.find("/gamedata/") != std::string::npos)
    {
        Msg("! Cannot open optional script file [%s]", cfg_full_name);
    }
    else
    {
        Msg("! Cannot open script file [%s]", cfg_full_name);
    }

[Xottab-DUTY]

Oops, sorry!
This was fixed in 947749c.