Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex to simple language change in the Security section of the extending contract #5233

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Complex to simple language change in the Security section of the extending contract #5233

wants to merge 6 commits into from
+1 −1

Conversation

Shaykoo
Copy link

@Shaykoo Shaykoo commented Sep 30, 2024

While reading the documentation the text was not clear and made me confuse. hence, the solution.

Screenshot 2024-09-30 at 10 53 19 PM Screenshot 2024-09-30 at 10 53 32 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 57859e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Oct 1, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Amxx
Copy link
Collaborator

Amxx commented Oct 1, 2024

Note: changing the packages while doing documentation changes is a big NO to me. It may not be one, but it looks like an "attack" that would hide harmfull changes to the dependencies

@Amxx
Revert "Add changeset"
7cb57cb 
This reverts commit 7f51161.
@Shaykoo
Copy link
Author

Shaykoo commented Oct 1, 2024

Note: changing the packages while doing documentation changes is a big NO to me. It may not be one, but it looks like an "attack" that would hide harmfull changes to the dependencies

Thanks @Amxx I will revert and commit again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaykoo @Amxx