Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Verify that all Opencast API calls use the Opencast PHP Library #38

Open
abias opened this issue Feb 25, 2025 · 1 comment · May be fixed by #39
Open

Refactoring: Verify that all Opencast API calls use the Opencast PHP Library #38

abias opened this issue Feb 25, 2025 · 1 comment · May be fixed by #39
Assignees
@ferishili
Labels
refactoring Something which needs to be refactored in the plugin (which may mean breaking changes)

Comments

@abias
Copy link
Member

abias commented Feb 25, 2025

It has to be checked if really all features of this plugin call the Opencast API via the Opencast PHP library (https://github.com/elan-ev/opencast-php-library).

If yes, then this issue can be directly closed.
If not, these features have to be refactored to use it.
@abias abias added the refactoring Something which needs to be refactored in the plugin (which may mean breaking changes) label Feb 25, 2025
@abias abias moved this to Ready for DEV in Opencast-Moodle Planning Board Feb 25, 2025
@ferishili ferishili self-assigned this Feb 26, 2025
@ferishili ferishili moved this from Ready for DEV to In Progress DEV in Opencast-Moodle Planning Board Feb 26, 2025
@ferishili
Copy link

ferishili commented Feb 26, 2025 •
edited
Loading

❌ I found a place in this plugin, that still uses the old API call! PR will follow!

ferishili added a commit that referenced this issue Mar 1, 2025
@ferishili
using oc php library,
f44dcb7 
fixes #38
@ferishili ferishili linked a pull request Mar 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferishili ferishili

Labels
refactoring Something which needs to be refactored in the plugin (which may mean breaking changes)
Projects
Opencast-Moodle Planning Board
Status: In Progress DEV
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure repository uses Opencat PHP library Opencast-Moodle/moodle-repository_opencast
2 participants
@abias @ferishili