refactor: internalize manual-mode guards into strategies and inject

Author: Tarquinen

lib/hooks.ts

@@ -112,18 +112,12 @@ export function createChatMessageTransformHandler(
         syncToolCache(state, config, logger, output.messages)
         buildToolIdList(state, output.messages, logger)
 
-        const shouldApplyStrategies = !state.manualMode || config.manualMode.automaticStrategies
-        if (shouldApplyStrategies) {
-            deduplicate(state, logger, config, output.messages)
-            supersedeWrites(state, logger, config, output.messages)
-            purgeErrors(state, logger, config, output.messages)
-        }
+        deduplicate(state, logger, config, output.messages)
+        supersedeWrites(state, logger, config, output.messages)
+        purgeErrors(state, logger, config, output.messages)
 
         prune(state, logger, config, output.messages)
-
-        if (!state.manualMode) {
-            insertPruneToolContext(state, config, logger, output.messages)
-        }
+        insertPruneToolContext(state, config, logger, output.messages)
 
         applyPendingManualTriggerPrompt(state, output.messages, logger)
 

lib/messages/inject.ts

@@ -215,6 +215,10 @@ export const insertPruneToolContext = (
     logger: Logger,
     messages: WithParts[],
 ): void => {
+    if (state.manualMode) {
+        return
+    }
+
     const pruneEnabled = config.tools.prune.permission !== "deny"
     const distillEnabled = config.tools.distill.permission !== "deny"
     const compressEnabled = config.tools.compress.permission !== "deny"

lib/strategies/deduplication.ts

@@ -15,6 +15,10 @@ export const deduplicate = (
     config: PluginConfig,
     messages: WithParts[],
 ): void => {
+    if (state.manualMode && !config.manualMode.automaticStrategies) {
+        return
+    }
+
     if (!config.strategies.deduplication.enabled) {
         return
     }

lib/strategies/purge-errors.ts

@@ -18,6 +18,10 @@ export const purgeErrors = (
     config: PluginConfig,
     messages: WithParts[],
 ): void => {
+    if (state.manualMode && !config.manualMode.automaticStrategies) {
+        return
+    }
+
     if (!config.strategies.purgeErrors.enabled) {
         return
     }

lib/strategies/supersede-writes.ts

@@ -18,6 +18,10 @@ export const supersedeWrites = (
     config: PluginConfig,
     messages: WithParts[],
 ): void => {
+    if (state.manualMode && !config.manualMode.automaticStrategies) {
+        return
+    }
+
     if (!config.strategies.supersedeWrites.enabled) {
         return
     }