From 812153ea9b394a775feedd74aafea8a24a2e4170 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Mon, 5 Dec 2022 11:40:33 +0100 Subject: [PATCH 01/23] Try to add code-sniffer to pa11y-ci --- build/.pa11yci.json | 7 +- site/assets/js/code-examples.js | 4 +- site/content/docs/5.2/components/navbar.md | 7 +- site/content/docs/5.2/components/offcanvas.md | 2 +- .../docs/5.2/components/orange-navbar.md | 2 +- site/content/docs/5.2/components/toasts.md | 32 ++++--- .../docs/5.2/examples/cards-rtl/index.html | 72 ++++++++-------- .../docs/5.2/examples/cards/index.html | 72 ++++++++-------- site/content/docs/5.2/forms/checks-radios.md | 86 +++++++++---------- site/content/docs/5.2/forms/overview.md | 1 + site/layouts/shortcodes/example.html | 4 +- site/layouts/shortcodes/placeholder.html | 2 +- 12 files changed, 144 insertions(+), 147 deletions(-) diff --git a/build/.pa11yci.json b/build/.pa11yci.json index fec193bd6e..d5c968e6c5 100644 --- a/build/.pa11yci.json +++ b/build/.pa11yci.json @@ -1,5 +1,5 @@ { - "standard": "WCAG2AA", + "standard": "WCAG2AAA", "level": "error", "defaults": { "chromeLaunchConfig": { @@ -12,10 +12,11 @@ ["pa11y-ci-reporter-html", {"destination": ".pa11y", "includeZeroIssues": true}] ], "runners": [ - "axe" + "axe", + "htmlcs" ], "useIncognitoBrowserContext": false, - "hideElements": "iframe, #text-decoration + p + div a.text-decoration-none, .accordion-collapse, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar", + "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar", "ignore": [ "color-contrast" ] diff --git a/site/assets/js/code-examples.js b/site/assets/js/code-examples.js index 07962695b4..f657a2c80f 100644 --- a/site/assets/js/code-examples.js +++ b/site/assets/js/code-examples.js @@ -22,8 +22,8 @@ const btnHtml = [ '
', '
', - ' ', '
', '
' diff --git a/site/content/docs/5.2/components/navbar.md b/site/content/docs/5.2/components/navbar.md index dd2244f33e..75a90da7a2 100644 --- a/site/content/docs/5.2/components/navbar.md +++ b/site/content/docs/5.2/components/navbar.md @@ -127,7 +127,7 @@ The `.navbar-brand` can be used to contain most elements, but an anchor works be ### Nav -Navbar navigation links build on our `.nav` options with their own modifier class and require the use of [toggler classes](#toggler) for proper responsive styling. **Navigation in navbars will also grow to occupy as much horizontal space as possible** to keep your navbar contents securely aligned. +Navbar navigation links build on our `.nav` options with their own modifier class and require the use of toggler classes for proper responsive styling. **Navigation in navbars will also grow to occupy as much horizontal space as possible** to keep your navbar contents securely aligned. Add the `.active` class on `.nav-link` to indicate the current page. @@ -271,6 +271,7 @@ Input groups work, too. If your navbar is an entire form, or mostly a form, you @ + {{< /example >}} @@ -279,10 +280,10 @@ Various buttons are supported as part of these navbar forms, too. This is also a {{< example >}} {{< /example >}} diff --git a/site/content/docs/5.2/components/offcanvas.md b/site/content/docs/5.2/components/offcanvas.md index 61d6ce5dcb..3c772f6036 100644 --- a/site/content/docs/5.2/components/offcanvas.md +++ b/site/content/docs/5.2/components/offcanvas.md @@ -13,7 +13,7 @@ toc: true Offcanvas is a sidebar component that can be toggled via JavaScript to appear from the left, right, top or bottom edge of the viewport. Buttons or anchors are used as triggers that are attached to specific elements you toggle, and `data` attributes are used to invoke our JavaScript. - Offcanvas shares some of the same JavaScript code as modals. Conceptually, they are quite similar, but they are separate plugins. -- Similarly, some [source Sass](#sass) variables for offcanvas's styles and dimensions are inherited from the modal's variables. +- Similarly, some [source Sass](#sass-variables) variables for offcanvas's styles and dimensions are inherited from the modal's variables. - When shown, offcanvas includes a default backdrop that can be clicked to hide the offcanvas. - Similar to modals, only one offcanvas can be shown at a time. diff --git a/site/content/docs/5.2/components/orange-navbar.md b/site/content/docs/5.2/components/orange-navbar.md index 36bfdb8f86..39f55d1965 100644 --- a/site/content/docs/5.2/components/orange-navbar.md +++ b/site/content/docs/5.2/components/orange-navbar.md @@ -221,7 +221,7 @@ Even though you should use the Master or Small logo, you can still replace it by {{< callout warning >}} You should consider having a **responsive SVG logo**. In order to do so, you may set up a responsive rendering into your SVG, [as we do with the Master logo]({{< docsref "/about/brand#orange-logo" >}}). -If you do not intend to use your own SVG, you should explore the DOM solution and therefore do as if you had a [title on one or two lines]({{< ref "#global-header-with-title" >}}). +If you do not intend to use your own SVG, you should explore the DOM solution and therefore do as if you had a [title on one or two lines]({{< ref "#with-title" >}}). {{< /callout >}}
diff --git a/site/content/docs/5.2/components/toasts.md b/site/content/docs/5.2/components/toasts.md index 8277811944..3ae9621991 100644 --- a/site/content/docs/5.2/components/toasts.md +++ b/site/content/docs/5.2/components/toasts.md @@ -200,23 +200,21 @@ Building on the above example, you can create different toast color schemes with Place toasts with custom CSS as you need them. The top right is often used for notifications, as is the top middle. If you're only ever going to show one toast at a time, put the positioning styles right on the `.toast`. {{< example stackblitz_add_js="true" >}} -
-
- - -
-
+
+ + +
diff --git a/site/content/docs/5.2/examples/cards-rtl/index.html b/site/content/docs/5.2/examples/cards-rtl/index.html index 0d6d30df59..43791d4806 100644 --- a/site/content/docs/5.2/examples/cards-rtl/index.html +++ b/site/content/docs/5.2/examples/cards-rtl/index.html @@ -72,15 +72,15 @@

عنوان

شرح

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -368,7 +368,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -378,7 +378,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -388,7 +388,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -399,22 +399,22 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}
-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -442,7 +442,7 @@

بطاقات على الأسود

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -451,7 +451,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -461,7 +461,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -471,7 +471,7 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}

عنوان

@@ -482,22 +482,22 @@

عنوان

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}
-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="تعليق على الصورة" >}}
-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -367,7 +367,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -377,7 +377,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -387,7 +387,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -398,22 +398,22 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}
-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -441,7 +441,7 @@

Cards on black

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -450,7 +450,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -460,7 +460,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -470,7 +470,7 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

@@ -481,22 +481,22 @@

Title

-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}
-
+
{{< placeholder width="100%" height="162" class="card-img-top" text="Image cap" >}}

Title

diff --git a/site/content/docs/5.2/forms/checks-radios.md b/site/content/docs/5.2/forms/checks-radios.md index eb2ec52b2a..cd9cbd6692 100644 --- a/site/content/docs/5.2/forms/checks-radios.md +++ b/site/content/docs/5.2/forms/checks-radios.md @@ -363,26 +363,24 @@ Drop borders using `.btn-no-outline`, too. Star rating system is built on top of radios. Simply add `.star-rating` to a `
` element to use predefined glyphs and compose your star rating system with as much stars as needed. {{< example >}} -
-
- Results relevance +
+ Results relevance - - + + - - + + - - + + - - + + - - -
- + + +
{{< /example >}} ### Sizes @@ -390,26 +388,24 @@ Star rating system is built on top of radios. Simply add `.star-rating` to a `}} -
-
- Results relevance +
+ Results relevance - - + + - - + + - - + + - - + + - - -
- + + +
{{< /example >}} ### Dark variant @@ -417,26 +413,24 @@ Star ratings come with a smaller variant: `.star-rating-sm`. Add `.star-rating-dark` to the `.star-rating` for a dark variant. {{< example class="bg-dark" >}} -
-
- Results relevance +
+ Results relevance - - + + - - + + - - + + - - + + - - -
- + + +
{{< /example >}} ### Disabled @@ -445,6 +439,8 @@ Make star ratings look inactive inside or outside a form by adding the `disabled {{< example >}}
+ Rated 3 stars out of 5 + diff --git a/site/content/docs/5.2/forms/overview.md b/site/content/docs/5.2/forms/overview.md index 2d0edb5d18..fadf867f89 100644 --- a/site/content/docs/5.2/forms/overview.md +++ b/site/content/docs/5.2/forms/overview.md @@ -143,6 +143,7 @@ Use the `.is-required` class on `label` to add a `*` symbol after it. {{< example >}}
+ Required fields inside fieldset example
diff --git a/site/layouts/shortcodes/example.html b/site/layouts/shortcodes/example.html index 071fbc2590..26dc59c474 100644 --- a/site/layouts/shortcodes/example.html +++ b/site/layouts/shortcodes/example.html @@ -33,10 +33,10 @@ {{- $lang -}}
diff --git a/site/layouts/shortcodes/placeholder.html b/site/layouts/shortcodes/placeholder.html index efa3f3b3ec..8f00b101c7 100644 --- a/site/layouts/shortcodes/placeholder.html +++ b/site/layouts/shortcodes/placeholder.html @@ -12,7 +12,7 @@ */ -}} {{- $grays := $.Site.Data.grays -}} -{{- $default_color := (index $grays 5).hex -}} +{{- $default_color := (index $grays 8).hex -}} {{- $default_background := (index $grays 3).hex -}} {{- $title := .Get "title" | default "Placeholder" -}} From 9108d61aa5bfd83ff5e29381b80af9dcdfba8dc8 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Wed, 18 Jan 2023 17:12:20 +0100 Subject: [PATCH 02/23] fix --- site/content/docs/5.2/customize/color-modes.md | 6 +++--- site/content/docs/5.2/customize/color.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/site/content/docs/5.2/customize/color-modes.md b/site/content/docs/5.2/customize/color-modes.md index ffc63cb16f..64bd823588 100644 --- a/site/content/docs/5.2/customize/color-modes.md +++ b/site/content/docs/5.2/customize/color-modes.md @@ -11,7 +11,7 @@ added: "5.3" **Bootstrap now supports color modes, starting with dark mode!** With v5.3.0 you can implement your own color mode toggler (see below for an example from Bootstrap's docs) and apply the different color modes as you see fit. We support a light mode (default) and now dark mode. Color modes can be toggled globally on the `` element, or on specific components and elements, thanks to the `data-bs-theme` attribute. -Alternatively, you can also switch to a media query implementation thanks to our color mode mixin—see [the usage section for details](#sass-usage). Heads up though—this eliminates your ability to change themes on a per-component basis as shown below. +Alternatively, you can also switch to a media query implementation thanks to our color mode mixin—see [the usage section for details](#usage). Heads up though—this eliminates your ability to change themes on a per-component basis as shown below. ## Example @@ -256,7 +256,7 @@ Here's a look at the JavaScript that powers it. Feel free to inspect our own doc ### Variables -Dozens of root level CSS variables are repeated as overrides for dark mode. These are scoped to the color mode selector, which defaults to `data-bs-theme` but [can be configured](#sass-usage) to use a `prefers-color-scheme` media query. Use these variables as a guideline for generating your own new color modes. +Dozens of root level CSS variables are repeated as overrides for dark mode. These are scoped to the color mode selector, which defaults to `data-bs-theme` but [can be configured](#usage) to use a `prefers-color-scheme` media query. Use these variables as a guideline for generating your own new color modes. {{< scss-docs name="root-dark-mode-vars" file="scss/_root.scss" >}} @@ -268,6 +268,6 @@ CSS variables for our dark color mode are partially generated from dark mode spe ### Sass mixin -Styles for dark mode, and any custom color modes you create, can be scoped appropriately to the `data-bs-theme` attribute selector or media query with the customizable `color-mode()` mixin. See the [Sass usage section](#sass-usage) for more details. +Styles for dark mode, and any custom color modes you create, can be scoped appropriately to the `data-bs-theme` attribute selector or media query with the customizable `color-mode()` mixin. See the [Sass usage section](#usage) for more details. {{< scss-docs name="color-mode-mixin" file="scss/mixins/_color-mode.scss" >}} diff --git a/site/content/docs/5.2/customize/color.md b/site/content/docs/5.2/customize/color.md index 6521a7dce3..6a8f460650 100644 --- a/site/content/docs/5.2/customize/color.md +++ b/site/content/docs/5.2/customize/color.md @@ -498,7 +498,7 @@ Colors ending in `-rgb` provide the `red, green, blue` values for use in `rgb()` These new colors are accessible via CSS variables and utility classes—like `--bs-primary-bg-subtle` and `.bg-primary-subtle`—allowing you to compose your own CSS rules with the variables, or to quickly apply styles via classes. The utilities are built with the color's associated CSS variables, and since we customize those CSS variables for dark mode, they are also adaptive to color mode by default. {{< example >}} -
+
Example element with utilities
{{< /example >}} From 83359ef60b72c4fd9c60ae63556c1b53cca53ed7 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Tue, 21 Mar 2023 13:40:28 +0100 Subject: [PATCH 03/23] Change because of losing `position: absolute` --- build/.pa11yci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/.pa11yci.json b/build/.pa11yci.json index a3999a265a..472e329958 100644 --- a/build/.pa11yci.json +++ b/build/.pa11yci.json @@ -16,7 +16,7 @@ "htmlcs" ], "useIncognitoBrowserContext": false, - "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .table-swatches, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar", + "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .table-swatches, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar, caption.visually-hidden", "ignore": [ "color-contrast" ] From 172f8a28855c38cc5008851092a7129e45bd2307 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Tue, 11 Apr 2023 10:12:38 +0200 Subject: [PATCH 04/23] fix(review) --- build/.pa11yci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/.pa11yci.json b/build/.pa11yci.json index 472e329958..c7cb7a14b9 100644 --- a/build/.pa11yci.json +++ b/build/.pa11yci.json @@ -1,5 +1,5 @@ { - "standard": "WCAG2AAA", + "standard": "WCAG2AA", "level": "error", "defaults": { "chromeLaunchConfig": { From 4ca39a3fb41e264bf33e68eab5147c8f5a28045c Mon Sep 17 00:00:00 2001 From: louismaximepiton Date: Thu, 13 Apr 2023 13:16:26 +0200 Subject: [PATCH 05/23] . --- site/content/docs/5.3/layout/containers.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/docs/5.3/layout/containers.md b/site/content/docs/5.3/layout/containers.md index fc461763c8..97dcaf733d 100644 --- a/site/content/docs/5.3/layout/containers.md +++ b/site/content/docs/5.3/layout/containers.md @@ -23,7 +23,7 @@ The table below illustrates how each container's `max-width` compares to the ori See them in action and compare them in our [Grid example]({{< docsref "/examples/grid#containers" >}}). -Please note that we apply an extra-padding on our containers (see [our mixins](#mixins)) +Please note that we apply an extra-padding on our containers (see [our mixins](#sass-mixins)) {{< bs-table "table" >}} | | Extra small
<480px
| Small
≥480px
| Medium
≥768px
| Large
≥1024px
| X-Large
≥1280px
| XX-Large
≥1440px
| From a94e6d558508f5e2a9ab49d11a931b2efeeac356 Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Tue, 25 Apr 2023 18:48:49 +0200 Subject: [PATCH 06/23] . --- build/.pa11yci.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/.pa11yci.json b/build/.pa11yci.json index c7cb7a14b9..530469efd4 100644 --- a/build/.pa11yci.json +++ b/build/.pa11yci.json @@ -16,7 +16,7 @@ "htmlcs" ], "useIncognitoBrowserContext": false, - "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .table-swatches, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar, caption.visually-hidden", + "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar, caption.visually-hidden", "ignore": [ "color-contrast" ] From 7549e72276a144550dc95568a25742bf9639226d Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Wed, 26 Apr 2023 09:09:30 +0200 Subject: [PATCH 07/23] . --- scss/_variables.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index be392791b8..891f0eef5b 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -342,13 +342,13 @@ $theme-colors: ( // scss-docs-end theme-colors-map // scss-docs-start theme-text-variables -$primary-text-emphasis: $primary !default; // Boosted mod: instead of `shade-color($primary, 60%)` -$secondary-text-emphasis: $secondary !default; // Boosted mod: instead of `shade-color($secondary, 60%)` +$primary-text-emphasis: null !default; // Boosted mod: instead of `shade-color($primary, 60%)` +$secondary-text-emphasis: null !default; // Boosted mod: instead of `shade-color($secondary, 60%)` $success-text-emphasis: null !default; // Boosted mod: instead of `shade-color($success, 60%)` $info-text-emphasis: null !default; // Boosted mod: instead of `shade-color($info, 60%)` $warning-text-emphasis: null !default; // Boosted mod: instead of `shade-color($warning, 60%)` $danger-text-emphasis: null !default; // Boosted mod: instead of `shade-color($danger, 60%)` -$light-text-emphasis: $light !default; // Boosted mod: instead of `$gray-700` +$light-text-emphasis: null !default; // Boosted mod: instead of `$gray-700` $dark-text-emphasis: null !default; // Boosted mod: instead of `$gray-700` // scss-docs-end theme-text-variables From bc35bf4f3bbc2f00763df7e2d9729544c01e287d Mon Sep 17 00:00:00 2001 From: "louismaxime.piton" Date: Thu, 27 Jul 2023 14:25:18 +0200 Subject: [PATCH 08/23] Fix CI --- build/.pa11yci.json | 2 +- scss/_variables.scss | 2 +- site/assets/scss/_content.scss | 2 +- site/content/docs/5.3/components/navbar.md | 5 ++- site/content/docs/5.3/customize/color.md | 2 +- .../docs/5.3/examples/download-app/index.html | 32 ++++++++----------- .../content/docs/5.3/examples/grid/index.html | 7 ++-- .../docs/5.3/examples/masonry/index.html | 2 +- .../content/docs/5.3/helpers/colored-links.md | 6 ++-- site/content/docs/5.3/helpers/icon-link.md | 2 +- .../docs/5.3/helpers/stretched-link.md | 2 +- 11 files changed, 32 insertions(+), 32 deletions(-) diff --git a/build/.pa11yci.json b/build/.pa11yci.json index 981ac12b36..e6870871ce 100644 --- a/build/.pa11yci.json +++ b/build/.pa11yci.json @@ -16,7 +16,7 @@ "htmlcs" ], "useIncognitoBrowserContext": false, - "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar, caption.visually-hidden, .overflow-y-scroll, .overflow-y-auto, .overflow-x-scroll, .overflow-x-auto, .table-responsive", + "hideElements": ".d-none, iframe, .accordion-sm .accordion-button, .accordion-collapse, .table-dark .table-active, .text-primary, a.active, a.disabled, .page-item.disabled, :disabled + label, .is-disabled, #text-decoration + p + div a.text-decoration-none, .bg-light code, #offcanvas, #offcanvasDark, #offcanvasResponsive, #bdSidebar, caption.visually-hidden, .overflow-y-scroll, .overflow-y-auto, .overflow-x-scroll, .overflow-x-auto, .table-responsive, .exclude-from-pa11y-analysis", "ignore": [ "color-contrast" ] diff --git a/scss/_variables.scss b/scss/_variables.scss index d62986e2c3..8857e542d7 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -829,7 +829,7 @@ $initialism-font-size: $small-font-size !default; $blockquote-margin-y: $spacer !default; $blockquote-font-size: $font-size-xlg !default; -$blockquote-footer-color: $gray-700 !default; +$blockquote-footer-color: var(--#{$prefix}secondary-color) !default; // Boosted mod: instead of `$gray-700` $blockquote-footer-font-size: $small-font-size !default; $blockquote-line-height: 1.5 !default; // Boosted mod $blockquote-letter-spacing: $letter-spacing-base * .25 !default; // Boosted mod diff --git a/site/assets/scss/_content.scss b/site/assets/scss/_content.scss index d30078f968..7b5fe7b480 100644 --- a/site/assets/scss/_content.scss +++ b/site/assets/scss/_content.scss @@ -116,7 +116,7 @@ } .btn-secondary { - --bs-btn-color: var(--bs-white); // Boosted mod + --bs-btn-color: var(--bs-dark); // Boosted mod --bs-btn-bg: #{mix($gray-600, $blue-400, .5)}; --bs-btn-border-color: #{rgba($white, .25)}; --bs-btn-hover-bg: #{darken(mix($gray-600, $blue-400, .5), 5%)}; diff --git a/site/content/docs/5.3/components/navbar.md b/site/content/docs/5.3/components/navbar.md index 2a210d9a8c..8f5c2dfbf5 100644 --- a/site/content/docs/5.3/components/navbar.md +++ b/site/content/docs/5.3/components/navbar.md @@ -595,7 +595,10 @@ When using offcanvas in a dark navbar, be aware that you may need to have a dark {{< example stackblitz_add_js="true" >}}