Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove url-specific parser (align with grammar) #3364

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

fabricereix
Copy link
Collaborator

@fabricereix fabricereix commented Nov 2, 2024

This will accept more characters in urls.

For example

Currently

$ echo 'GET http://localhost?q={}' | hurlfmt
error: Parsing URL
  --> -:1:24
   |
 1 | GET http://localhost?q={}
   |                        ^ illegal character <{>
   |

With this update

$ echo 'GET http://localhost?q={}' | hurlfmt
GET http://localhost?q={}

Note that in curl, the curly bracket needs to be escaped
curl 'http://localhost:8000/querystring-params?param1=value1&param2=&param3=a%3Db&param4=1%2C2%2C3&param5=\{bar\}&$top=5'
or use the option g/--globoff.
This must be taken into account when reviewing curl export.

@fabricereix fabricereix linked an issue Nov 2, 2024 that may be closed by this pull request
@fabricereix fabricereix force-pushed the parsing/url-align-with-grammar branch 4 times, most recently from 79ea724 to 0f2ad77 Compare November 3, 2024 09:16
@jcamiel
Copy link
Collaborator

jcamiel commented Nov 4, 2024

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Nov 4, 2024

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Nov 4, 2024

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, Orange-OpenSource/hurl/parsing/url-align-with-grammar now embeds these commits:

@hurl-bot
Copy link
Collaborator

hurl-bot commented Nov 4, 2024

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the parsing/url-align-with-grammar branch from 0f2ad77 to e341af5 Compare November 4, 2024 12:49
@hurl-bot
Copy link
Collaborator

hurl-bot commented Nov 4, 2024

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/parsing/url-align-with-grammar branch into Orange-OpenSource/hurl/master branch:

  • e341af5 Remove url-specific parser (align with grammar)

@hurl-bot hurl-bot closed this Nov 4, 2024
@hurl-bot hurl-bot merged commit e341af5 into master Nov 4, 2024
24 checks passed
@hurl-bot hurl-bot deleted the parsing/url-align-with-grammar branch November 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url parsing: align parsing implementation with grammar
3 participants