feat: add grid tokens in the demo app #149
Conversation
🟢 Netlify deploy for commit 7fabe55 succeededDeploy preview: https://671bb14781a5f44fb5d48ae3--ouds-android.netlify.app |
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
645695a
to
ff59ad1
Compare
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
ff59ad1
to
749d659
Compare
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
749d659
to
167b8f8
Compare
… of TokenProperty
Factorize token properties illustrations
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
167b8f8
to
321fd5d
Compare
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
884eda8
to
6a464b3
Compare
paulinea
force-pushed
the
122-add-grid-tokens-in-the-demo-app
branch
from
6a464b3
to
d846e48
Compare
There was a problem hiding this comment.
Resolution of this resource is the same as the xxhdpi version and is different from the xxxhdpi light version, so I suppose this is not the correct resource.
Same comment for il_tokens_grid_max_width.png and il_tokens_grid_min_width.png.
| @@ -121,14 +125,14 @@ fun TokenCategoryDetailScreen(tokenCategory: TokenCategory, onSubcategoryClick: | |||
| Column( | |||
| modifier = Modifier | |||
| .weight(1f) | |||
| .padding(start = if (isTypographyProperty) OudsSpaceKeyToken.Fixed.None.value else OudsSpaceKeyToken.Fixed.Medium.value) | |||
| .padding(start = if (noIllustrationProperty) OudsSpaceKeyToken.Fixed.None.value else OudsSpaceKeyToken.Fixed.Medium.value) | |||
There was a problem hiding this comment.
It's also possible to remove the padding here and use the horizontalArrangement parameter of the Row to achieve the same effect:
horizontalArrangement = Arrangement.spacedBy(OudsSpaceKeyToken.Fixed.Medium.value)This allows to get rid of the noIllustrationProperty variable too.
|
|
||
| @Composable | ||
| fun GridIllustrations() { | ||
| Image( |
There was a problem hiding this comment.
Rendering is correct but images could be in a column to ensure this method will still work if we change the container. We could also factorize several properties:
@Composable
fun GridIllustrations() {
Column(
modifier = Modifier.padding(horizontal = OudsSpaceKeyToken.Fixed.Medium.value),
verticalArrangement = Arrangement.spacedBy(OudsSpaceKeyToken.Fixed.Medium.value)
) {
val resourceIds = listOf(
R.drawable.il_tokens_grid_column_margin,
R.drawable.il_tokens_grid_min_width,
R.drawable.il_tokens_grid_max_width
)
resourceIds.forEach {
Image(
modifier = Modifier
.fillMaxWidth()
.background(OudsColorKeyToken.OnSurface.value), //TODO use BgEmphasizedPrimary token when available
painter = painterResource(id = it),
contentDescription = null
)
}
}
}
No description provided.