Every issue above describing a mock-to-real migration (Soroban calls, Horizon submission, federation SEP-2, SEP-24 off-ramp) will need integration tests against at least a testnet, which requires test fixtures/funded testnet accounts and a CI strategy for network-dependent tests (retry/flake handling, secrets for testnet keys) that doesn't exist in the current all-mocked, all-deterministic test suite.
Definition of done:
- CI strategy defined for testnet-dependent integration tests (separate job, funded test account provisioning, retry policy)
- At least one real integration (pick the smallest — likely federation SEP-2 lookup) has a testnet-backed integration test as a template for the rest
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.
Every issue above describing a mock-to-real migration (Soroban calls, Horizon submission, federation SEP-2, SEP-24 off-ramp) will need integration tests against at least a testnet, which requires test fixtures/funded testnet accounts and a CI strategy for network-dependent tests (retry/flake handling, secrets for testnet keys) that doesn't exist in the current all-mocked, all-deterministic test suite.
Definition of done:
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.