Currently sendPayment's fake success returns instantly-ish (no real network latency, no real failure modes), so the UI doesn't need to handle a submitted-but-not-yet-confirmed state. Once real Horizon submission lands (see issue above), the send flow needs an optimistic "pending" state immediately on submit, with rollback/error UI if the real submission fails after the optimistic update already rendered.
Definition of done:
- Optimistic transaction entry appended to the UI immediately on submit
- Rollback (removal or error-state marking) if the real submission subsequently fails
- No duplicate entry once the real confirmed transaction syncs in
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.
Currently
sendPayment's fake success returns instantly-ish (no real network latency, no real failure modes), so the UI doesn't need to handle a submitted-but-not-yet-confirmed state. Once real Horizon submission lands (see issue above), the send flow needs an optimistic "pending" state immediately on submit, with rollback/error UI if the real submission fails after the optimistic update already rendered.Definition of done:
Before opening a PR for this issue, read CONTRIBUTING.md.
This is not a starter-issue. The Definition of done above is the full
acceptance criteria, not a subset to sample from — a PR that addresses part
of it is an unfinished issue, not a smaller one. Your PR must include, in
the PR description itself:
PRs missing these will be sent back before review, not reviewed and rejected — please do this up front.